Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

EOS-27348: add default val_args to MappedConf.get #714

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

rohit-k-dwivedi
Copy link
Contributor

@rohit-k-dwivedi rohit-k-dwivedi commented Jan 19, 2022

Signed-off-by: Rohit Dwivedi [email protected]

Problem Statement

  • Patch to accept default_val in MappedConf.get

Design

  • Added default_val arg in MappedConf

Coding

  • Coding conventions are followed and code is consistent [Y/N]: Y
  • Confirm All CODACY errors are resolved [Y/N]: Y

Testing

  • Confirm that Test Cases are added (for both the cases, fix and feature) [Y/N]:
  • Confirm Test Cases cover Happy Path, Non-Happy Path and Scalability [Y/N]:
  • Confirm Testing was performed with installed RPM [Y/N]:

Review Checklist

Before posting the PR please ensure

  • PR is self reviewed
  • Is there a change in filename/package/module or signature [Y/N]:
  • If yes for above point, Is a notification sent to all other cortx components [Y/N]
  • Jira is updated
  • Check if the description is clear and explained.
  • Check Acceptance Criterion is defined.
  • All the tests performed should be mentioned before Resolving a JIRA.
  • Verification needs to be done before marked as Closed/Verified

Documentation

  • Changes done to WIKI / Confluence page

@suryakumar1024
Copy link
Contributor

Fill PR template

Copy link
Contributor

@sachinpunadikar sachinpunadikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sachinpunadikar sachinpunadikar merged commit f531f4b into Seagate:main Jan 19, 2022
suryakumar1024 pushed a commit to suryakumar1024/cortx-utils that referenced this pull request Mar 21, 2022
Signed-off-by: Rohit Dwivedi <[email protected]>
Signed-off-by: suryakumar.kumaravelan <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants