Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

EOS-27348: Updated Iem and MessageBus server cortxconf usage removed #718

Merged
merged 7 commits into from
Jan 24, 2022
Merged

EOS-27348: Updated Iem and MessageBus server cortxconf usage removed #718

merged 7 commits into from
Jan 24, 2022

Conversation

suryakumar1024
Copy link
Contributor

@suryakumar1024 suryakumar1024 commented Jan 20, 2022 •
edited
Loading

Signed-off-by: suryakumar.kumaravelan [email protected]

Problem Statement

  • Since CortxConf class is no more in use, Need to update all the usage of this class all over the utils code.

Design

  • Removed the usage in IEM server and MessageServer scripts

Coding

  • Coding conventions are followed and code is consistent [Y/N]: Y
  • Confirm All CODACY errors are resolved [Y/N]: Y

Testing

  • Confirm that Test Cases are added (for both the cases, fix and feature) [Y/N]: N
  • Confirm Test Cases cover Happy Path, Non-Happy Path and Scalability [Y/N]: NA
  • Confirm Testing was performed with installed RPM [Y/N]: Y

Review Checklist

Before posting the PR please ensure

  • PR is self reviewed
  • Is there a change in filename/package/module or signature [Y/N]: N
  • If yes for above point, Is a notification sent to all other cortx components [Y/N]: NA
  • Jira is updated
  • Check if the description is clear and explained.
  • Check Acceptance Criterion is defined.
  • All the tests performed should be mentioned before Resolving a JIRA.
  • Verification needs to be done before marked as Closed/Verified

Documentation

  • Changes done to WIKI / Confluence page

@suryakumar1024
Added mappedconf class removed conf variable
0461c55 
Signed-off-by: suryakumar.kumaravelan <[email protected]>
rohit-k-dwivedi
rohit-k-dwivedi approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@rohit-k-dwivedi rohit-k-dwivedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sachinpunadikar
sachinpunadikar approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@sachinpunadikar sachinpunadikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@suryakumar1024 suryakumar1024 changed the title WIP: Updated Iem and MessageBus server cortxconf usage removed Updated Iem and MessageBus server cortxconf usage removed Jan 21, 2022
@suryakumar1024 suryakumar1024 changed the title Updated Iem and MessageBus server cortxconf usage removed EOS-27348: Updated Iem and MessageBus server cortxconf usage removed Jan 21, 2022
@sachinpunadikar
Copy link
Contributor

test this please

@sachinpunadikar
Copy link
Contributor

retest this please

@sachinpunadikar sachinpunadikar merged commit fc17375 into Seagate:main Jan 24, 2022
@sachinpunadikar sachinpunadikar deleted the iem_ms_conf branch January 24, 2022 07:12
suryakumar1024 added a commit to suryakumar1024/cortx-utils that referenced this pull request Mar 21, 2022
@suryakumar1024
EOS-27348: Updated Iem and MessageBus server cortxconf usage removed (S…
e7a0cbb 
…eagate#718)

* Updated Iem and MessageBus server cortx conf changes

Signed-off-by: suryakumar.kumaravelan <[email protected]>

* Added mappedconf class removed conf variable

Signed-off-by: suryakumar.kumaravelan <[email protected]>

* code opt

Signed-off-by: suryakumar.kumaravelan <[email protected]>

* Update utils_server.py

Co-authored-by: Sachin Punadikar <[email protected]>
Signed-off-by: suryakumar.kumaravelan <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rohit-k-dwivedi rohit-k-dwivedi rohit-k-dwivedi approved these changes

@sachinpunadikar sachinpunadikar sachinpunadikar approved these changes

@ujjwalpl ujjwalpl ujjwalpl approved these changes

@rahul-tripathi-git rahul-tripathi-git Awaiting requested review from rahul-tripathi-git

@ajaysrivas ajaysrivas Awaiting requested review from ajaysrivas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@suryakumar1024 @sachinpunadikar @ujjwalpl @rohit-k-dwivedi