This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 85
EOS-27348: Utils Mini Provisioning Setup: Removed usage of cortxconf class from utils setup #719
Merged
sachinpunadikar
merged 7 commits into
Seagate:main
from
suryakumar1024:utils_setup_cc_fix
Jan 24, 2022
Merged
EOS-27348: Utils Mini Provisioning Setup: Removed usage of cortxconf class from utils setup #719
sachinpunadikar
merged 7 commits into
Seagate:main
from
suryakumar1024:utils_setup_cc_fix
Jan 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: suryakumar.kumaravelan <[email protected]>
suryakumar1024
requested review from
sachinpunadikar,
vastradparayya and
rahul-tripathi-git
January 20, 2022 15:53
Signed-off-by: suryakumar.kumaravelan <[email protected]>
suryakumar1024
changed the title
WIP: Utils Setup: Removed usage of cortxconf class from utils setup
Utils Mini Provisioning Setup: Removed usage of cortxconf class from utils setup
Jan 20, 2022
ujjwalpl
suggested changes
Jan 21, 2022
Signed-off-by: suryakumar.kumaravelan <[email protected]>
suryakumar1024
changed the title
Utils Mini Provisioning Setup: Removed usage of cortxconf class from utils setup
EOS-27348: Utils Mini Provisioning Setup: Removed usage of cortxconf class from utils setup
Jan 21, 2022
Signed-off-by: suryakumar.kumaravelan <[email protected]>
sachinpunadikar
approved these changes
Jan 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Signed-off-by: suryakumar.kumaravelan <[email protected]>
rohit-k-dwivedi
approved these changes
Jan 21, 2022
ujjwalpl
approved these changes
Jan 21, 2022
vastradparayya
approved these changes
Jan 21, 2022
suryakumar1024
added a commit
to suryakumar1024/cortx-utils
that referenced
this pull request
Mar 21, 2022
…class from utils setup (Seagate#719) * Removed usage of cortxconf class from utils setup Signed-off-by: suryakumar.kumaravelan <[email protected]> * Code optimize Signed-off-by: suryakumar.kumaravelan <[email protected]> * Code opt Signed-off-by: suryakumar.kumaravelan <[email protected]> * Utils setup feedback changes Signed-off-by: suryakumar.kumaravelan <[email protected]> * Code optimize Signed-off-by: suryakumar.kumaravelan <[email protected]> Co-authored-by: Sachin Punadikar <[email protected]> Signed-off-by: suryakumar.kumaravelan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: suryakumar.kumaravelan [email protected]
Problem Statement
Design
Coding
Testing
Review Checklist
Before posting the PR please ensure
Documentation