Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

EOS-27348: Utils Mini Provisioning Setup: Removed usage of cortxconf class from utils setup #719

Merged
merged 7 commits into from
Jan 24, 2022

Conversation

suryakumar1024
Copy link
Contributor

@suryakumar1024 suryakumar1024 commented Jan 20, 2022

Signed-off-by: suryakumar.kumaravelan [email protected]

Problem Statement

  • Since CortxConf class is no more in use, Need to update all the usage of this class all over the utils code.

Design

  • Removed the cortxconf class usage in utils mini provisioning scripts

Coding

  • Coding conventions are followed and code is consistent [Y/N]: Y
  • Confirm All CODACY errors are resolved [Y/N]: Y

Testing

  • Confirm that Test Cases are added (for both the cases, fix and feature) [Y/N]: N
  • Confirm Test Cases cover Happy Path, Non-Happy Path and Scalability [Y/N]: NA
  • Confirm Testing was performed with installed RPM [Y/N]: Y

Review Checklist

Before posting the PR please ensure

  • PR is self reviewed
  • Is there a change in filename/package/module or signature [Y/N]: Y
  • If yes for above point, Is a notification sent to all other cortx components [Y/N]: Y
  • Jira is updated
  • Check if the description is clear and explained.
  • Check Acceptance Criterion is defined.
  • All the tests performed should be mentioned before Resolving a JIRA.
  • Verification needs to be done before marked as Closed/Verified

Documentation

  • Changes done to WIKI / Confluence page

Signed-off-by: suryakumar.kumaravelan <[email protected]>
@suryakumar1024 suryakumar1024 changed the title WIP: Utils Setup: Removed usage of cortxconf class from utils setup Utils Mini Provisioning Setup: Removed usage of cortxconf class from utils setup Jan 20, 2022
py-utils/src/setup/utils.py Outdated Show resolved Hide resolved
py-utils/src/setup/utils.py Outdated Show resolved Hide resolved
py-utils/src/setup/utils.py Outdated Show resolved Hide resolved
py-utils/src/setup/utils.py Outdated Show resolved Hide resolved
py-utils/src/setup/utils.py Outdated Show resolved Hide resolved
py-utils/src/setup/utils.py Outdated Show resolved Hide resolved
py-utils/src/setup/utils_setup.py Outdated Show resolved Hide resolved
@suryakumar1024 suryakumar1024 changed the title Utils Mini Provisioning Setup: Removed usage of cortxconf class from utils setup EOS-27348: Utils Mini Provisioning Setup: Removed usage of cortxconf class from utils setup Jan 21, 2022
Signed-off-by: suryakumar.kumaravelan <[email protected]>
Copy link
Contributor

@sachinpunadikar sachinpunadikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Signed-off-by: suryakumar.kumaravelan <[email protected]>
@sachinpunadikar sachinpunadikar merged commit 8e68eff into Seagate:main Jan 24, 2022
@sachinpunadikar sachinpunadikar deleted the utils_setup_cc_fix branch January 24, 2022 08:32
suryakumar1024 added a commit to suryakumar1024/cortx-utils that referenced this pull request Mar 21, 2022
…class from utils setup (Seagate#719)

* Removed usage of cortxconf class from utils setup

Signed-off-by: suryakumar.kumaravelan <[email protected]>

* Code optimize

Signed-off-by: suryakumar.kumaravelan <[email protected]>

* Code opt

Signed-off-by: suryakumar.kumaravelan <[email protected]>

* Utils setup feedback changes

Signed-off-by: suryakumar.kumaravelan <[email protected]>

* Code optimize

Signed-off-by: suryakumar.kumaravelan <[email protected]>

Co-authored-by: Sachin Punadikar <[email protected]>
Signed-off-by: suryakumar.kumaravelan <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants