fix: bump zxing-cpp to 579650a to fix incorrect PDF417 position info

[Sec-ant]

Summary by CodeRabbit

• New Features

  • Updated the zxing-cpp dependency to improve PDF417 barcode positioning accuracy.

• Bug Fixes

  • Corrected positioning information for PDF417 barcodes, enhancing scanning reliability.

• Tests

  • Adjusted JSON snapshots for PDF417 barcodes to reflect updated coordinates and orientations.

[changeset-bot]

🦋 Changeset detected

Latest commit: f6dd174

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
zxing-wasm	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request updates the zxing-wasm package by changing the dependency version of zxing-cpp to commit 579650a. This update addresses issues related to the positioning of PDF417 barcodes. Additionally, multiple JSON snapshot files representing PDF417 barcodes have been modified to reflect changes in the coordinates of the topRight and bottomRight corners, as well as adjustments to the orientation values. No other logic or functionality has been altered.

Changes

File Path	Change Summary
.changeset/curly-houses-bathe.md	Updated zxing-cpp dependency version to 579650a in zxing-wasm package.
zxing-cpp	Updated subproject commit reference from cd9bba33ef9cc175120f6e9ba49cc08b1f27a338 to 579650afbd9f156d36351980c85722c498426ddc.
tests/snapshots/pdf417-1/10/*.json	Updated topRight and bottomRight coordinates and orientation in multiple snapshots.
tests/snapshots/pdf417-2/25/*.json	Updated topRight and bottomRight coordinates and orientation in multiple snapshots.
tests/snapshots/pdf417-3/16/*.json	Updated topRight and bottomRight coordinates and orientation in multiple snapshots.
tests/snapshots/pdf417-3/17/*.json	Updated topRight and bottomRight coordinates and orientation in multiple snapshots.
tests/snapshots/pdf417-3/18/*.json	Updated topRight and bottomRight coordinates and orientation in multiple snapshots.

Possibly related PRs

• chore: bump zxing-cpp to d0c1f34 and add pkg.pr.new #103: Updates the zxing-cpp dependency to a new commit, directly related to the version bump in the main PR.
• Version Packages #105: Includes a patch that bumps the zxing-cpp dependency, aligning with the changes made in the main PR.
• chore: bump zxing-cpp and other dependencies #110: Involves an update to the zxing-cpp dependency, indicating a connection to the changes made.
• chore: bump zxing-cpp, switch to pnpm and renovate #127: Updates the zxing-cpp dependency and reflects a modernization effort in dependency management relevant to the main PR.
• Version Packages #130: Documents a version bump for the zxing-cpp dependency, directly relating to the changes in the main PR.
• fix: patch emscripten #152: Primarily focused on patching Emscripten but part of ongoing updates to the zxing-wasm project, which includes the zxing-cpp dependency.
• Version Packages #153: Includes a patch change addressing a vulnerability and mentions a bump of the zxing-cpp dependency, linking it to the main PR.
• Version Packages #154: Documents a version bump for the zxing-cpp dependency, relevant to the changes in the main PR.
• Version Packages #160: Includes a bump of the zxing-cpp dependency, indicating a direct relationship with the main PR's updates.
• Version Packages #164: Documents a version bump for the zxing-cpp dependency, aligning with the changes made in the main PR.

🐰 In the fields of code, we hop and play,
With barcodes adjusted, we brighten the day.
From topRight to bottom, we shift with delight,
Updating our paths, making everything right!
A version bump here, a patch over there,
In the world of zxing, we show that we care! 🐇

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[pkg-pr-new]

Open in Stackblitz

pnpm add https://pkg.pr.new/zxing-wasm@171

commit: f6dd174

[Sec-ant]

The 579650a fix seems to result in negative positions in some rotated barcodes, should the coordinates be clamped to zero? @axxel

[axxel]

You are right. Thanks for reporting. See zxing-cpp/zxing-cpp@22adcab