fix: out of bound positions

[Sec-ant]

Summary by CodeRabbit

• Bug Fixes

  • Adjusted the coordinates of the topRight and bottomRight positions in PDF417 barcode representations, improving accuracy in barcode rendering.

• Chores

  • Updated the subproject reference for zxing-cpp to a newer commit, ensuring the latest features and fixes are included.

[changeset-bot]

⚠️ No Changeset found

Latest commit: d853256

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The pull request introduces modifications to several JSON snapshots representing PDF417 barcodes. The primary changes involve adjustments to the topRight and bottomRight coordinates within the position object, specifically altering their x and y values in various snapshots. Additionally, the commit reference for the zxing-cpp subproject has been updated to a newer version. No changes were made to the declarations of exported or public entities.

Changes

File Path	Change Summary
tests/snapshots/pdf417-3/18/fast-0.json	Updated topRight and bottomRight x values from 404 to 375.
tests/snapshots/pdf417-3/18/fast-180.json	Updated topRight and bottomRight x values from -29 to 0.
tests/snapshots/pdf417-3/18/slow-0.json	Updated topRight and bottomRight x values from 404 to 375, y values unchanged.
tests/snapshots/pdf417-3/18/slow-180.json	Updated topRight and bottomRight x values from -29 to 0.
tests/snapshots/pdf417-3/18/slow-270.json	Updated topRight and bottomRight y values from 404 to 375, x values unchanged.
tests/snapshots/pdf417-3/18/slow-90.json	Updated topRight and bottomRight y values from -29 to 0.
zxing-cpp	Updated subproject commit reference from 579650afbd9f156d36351980c85722c498426ddc to 22adcab8bc1ecf8222452e05b6dd42380282966c.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant BarcodeGenerator
    participant SnapshotManager

    User->>BarcodeGenerator: Request Barcode Generation
    BarcodeGenerator->>SnapshotManager: Generate Snapshot
    SnapshotManager-->>BarcodeGenerator: Return Snapshot
    BarcodeGenerator-->>User: Provide Generated Barcode Snapshot

Loading

🐰 "In the land of codes and bars,
The rabbit hops beneath the stars.
With coordinates shifted just right,
Our barcodes now shine so bright!
A version updated, all is well,
Hooray for changes, let’s all yell!" 🥕

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[pkg-pr-new]

Open in Stackblitz

pnpm add https://pkg.pr.new/zxing-wasm@173

commit: d853256

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 1a9a372 and d853256.

📒 Files selected for processing (7)

• tests/__snapshots__/pdf417-3/18/fast-0.json (1 hunks)
• tests/__snapshots__/pdf417-3/18/fast-180.json (1 hunks)
• tests/__snapshots__/pdf417-3/18/slow-0.json (1 hunks)
• tests/__snapshots__/pdf417-3/18/slow-180.json (1 hunks)
• tests/__snapshots__/pdf417-3/18/slow-270.json (1 hunks)
• tests/__snapshots__/pdf417-3/18/slow-90.json (1 hunks)
• zxing-cpp (1 hunks)

✅ Files skipped from review due to trivial changes (4)

• tests/snapshots/pdf417-3/18/fast-180.json
• tests/snapshots/pdf417-3/18/slow-0.json
• tests/snapshots/pdf417-3/18/slow-180.json
• zxing-cpp

🔇 Additional comments (2)

tests/__snapshots__/pdf417-3/18/fast-0.json (1)

17-22: LGTM! Position coordinates adjusted to fix out-of-bounds detection.

The changes to topRight and bottomRight x-coordinates from 404 to 375 maintain the rectangular shape while addressing the out-of-bounds issue mentioned in the PR title.

tests/__snapshots__/pdf417-3/18/slow-270.json (1)

18-22: LGTM! The position coordinates are now valid.

The updated y-coordinates for topRight and bottomRight positions ensure all points are within bounds and form a valid quadrilateral shape.

Let's verify the consistency of position coordinates across other snapshot files: