-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translation Version Name in Title Bar #18
Comments
Hi @saengel! I'm working on this one. I'm checking the following:
Is there anything else you'd like me to check? |
|
Sefaria/Sefaria-Playwright-Tests#18 TODO: Decide if we want to test for default translation title.
I think that works for now! We can always add more later if needed. Thank you! |
Ok, sounds great! As mentioned in Discord, I found that there is no default translation title for Hebrew source language in any interface language. I can remove this part of the test if desired. I was originally testing the default source language, but I'm going to expand it to the usual interface/source combo of 4. |
There's an opportunity here for another function in Utils and some vars in Globals that will change the source language for us. I'll submit a PR and you can tell me what you think. |
(That being said, I already learned from this translation, so thanks for suggesting it as an example) |
Okay sounds good! Thank you for the efforts here. |
Title: Verify display of translation version name in the title bar.
Test:
contentLanguage
.The text was updated successfully, but these errors were encountered: