Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation Version Name in Title Bar #18

Open
saengel opened this issue Jun 6, 2024 · 8 comments
Open

Translation Version Name in Title Bar #18

saengel opened this issue Jun 6, 2024 · 8 comments
Assignees

Comments

@saengel
Copy link
Collaborator

saengel commented Jun 6, 2024

Title: Verify display of translation version name in the title bar.
Test:

  1. Open a translated text.
  2. Verify that the translation version name (e.g., "The Rashi chumash by Rabbi Shraga Silverstein") is displayed in English regardless of contentLanguage.
@b-w-cole
Copy link
Collaborator

Hi @saengel! I'm working on this one. I'm checking the following:

  • The default translation title matches what is 'Currently Selected' in the Translations selection sidebar
  • A newly selected translation reflects correctly in the title
  • The Russian characterset works
  • The interface language is intact for English and Hebrew

Is there anything else you'd like me to check?

@b-w-cole
Copy link
Collaborator

  • Adding Hebrew translation name characterset

b-w-cole added a commit to b-w-cole/Sefaria-Project that referenced this issue Jul 24, 2024
Sefaria/Sefaria-Playwright-Tests#18

TODO: Decide if we want to test for default translation title.
@saengel
Copy link
Collaborator Author

saengel commented Jul 25, 2024

I think that works for now! We can always add more later if needed. Thank you!

@b-w-cole
Copy link
Collaborator

Ok, sounds great! As mentioned in Discord, I found that there is no default translation title for Hebrew source language in any interface language. I can remove this part of the test if desired. I was originally testing the default source language, but I'm going to expand it to the usual interface/source combo of 4.

@b-w-cole
Copy link
Collaborator

There's an opportunity here for another function in Utils and some vars in Globals that will change the source language for us. I'll submit a PR and you can tell me what you think.

@b-w-cole
Copy link
Collaborator

Also, I noticed there is a bilingual aspect to translation names for Hebrew Interface/English Source only that I'm guessing is intentional, as I'm seeing a good number of translations that are spelled out in Hebrew.

image

@b-w-cole
Copy link
Collaborator

(That being said, I already learned from this translation, so thanks for suggesting it as an example)

@saengel
Copy link
Collaborator Author

saengel commented Aug 1, 2024

Okay sounds good! Thank you for the efforts here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

2 participants