fix(email subscriptions): Fix referring to nonexistent field on excep…

…tion object and catching another type of exception during error
Sefaria · Dec 23, 2024 · a676872 · a676872
1 parent 879d892
commit a676872
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/sefaria/helper/crm/salesforce.py b/sefaria/helper/crm/salesforce.py
@@ -168,5 +168,5 @@ def get_available_lists(self) -> list[str]:
             response = self.get(endpoint + "?q=SELECT+Subscriptions__c+FROM+AC_to_SF_List_Mapping__mdt")
             records = response.json()["records"]
             return [record["Subscriptions__c"] for record in records]
-        except (requests.RequestException, KeyError, json.JSONDecodeError):
+        except (requests.RequestException, KeyError, json.JSONDecodeError, AttributeError):
             raise SalesforceNewsletterListRetrievalError("Unable to retrieve newsletter mailing lists from Salesforce CRM")
diff --git a/sefaria/views.py b/sefaria/views.py
@@ -222,7 +222,7 @@ def get_available_newsletter_mailing_lists(request):
     try:
         return jsonResponse({"newsletter_mailing_lists": CrmMediator().get_available_lists()})
     except SalesforceNewsletterListRetrievalError as e:
-        return jsonResponse({"error": e.message}, status=502)
+        return jsonResponse({"error": str(e)}, status=502)
     except:
         return jsonResponse({"error": "Unknown error occurred"}, status=500)