Api final #1754
Merged
Api final #1754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…step is deprecating it).
edamboritz
previously approved these changes
Jan 4, 2024
| 'direction', # 'rtl' or 'ltr' | ||
| "actualLanguage", # ISO language code | ||
| 'languageFamilyName', # full name of the language, but without specificity (for Judeo Arabic actualLanguage=jrb, languageFamilyName=arabic | ||
| "isBaseText", # should be deprecated (needs some changes on client side) |
There was a problem hiding this comment.
can probs remove this line now
There was a problem hiding this comment.
no. we should deploy, then remove it from data, and then we can remove this line (and say everyone to remove it from data, doing it on shmuels' cauldron, etc.)
Deprecate isBaseText
edamboritz
approved these changes
Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc strings
change 400 to 404
refactor TextRange - change versions to be a private attribue with a pu bublic setter