Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): patches a bug where setting a url param to false or 0 would… #1792

Merged

Conversation

rneiss
Copy link
Contributor

@rneiss rneiss commented Jan 30, 2024

… return true at certain API endpoints.

@rneiss rneiss requested a review from edamboritz January 30, 2024 20:15
Copy link

Copy link
Contributor

@edamboritz edamboritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!
Have we made sure that client side code using these APIs in their bugged out state doesnt need to be corrected to match?
From looking at the code superficially it doesn't look like anything would break, but just making sure

@rneiss
Copy link
Contributor Author

rneiss commented Jan 31, 2024

This looks good! Have we made sure that client side code using these APIs in their bugged out state doesnt need to be corrected to match? From looking at the code superficially it doesn't look like anything would break, but just making sure

Yep. In each of these cases the client code always sent a 1 as the value or didn't include the attribute at all thus resulting in the proper falsey response.

@rneiss rneiss merged commit fe9c971 into master Jan 31, 2024
22 checks passed
@rneiss rneiss deleted the bug/sc-24022/several-api-endpoints-improperly-set-params branch January 31, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants