Chore/sc 28761/super about fit and finish page title #2135
Conversation
static/css/static.css
Outdated
| font-style: normal; | ||
| font-weight: 500; | ||
| font-size: 22px; | ||
| text-align: left; |
There was a problem hiding this comment.
shouldn't this be start (for left in english and right in hebrew)?
static/css/static.css
Outdated
| @@ -3538,7 +3520,16 @@ form.globalUpdateForm + div.notificationsList { | |||
| margin-right: 20px; | |||
| } | |||
| } | |||
| .interface-hebrew h1.aboutHeader, .interface-hebrew #aboutSidebar h1 { | |||
| text-align: right; | |||
There was a problem hiding this comment.
again, i thinkg the right way here is to be start, and something general that switches the direction in the hebrew interface
| text-align: right; | ||
| } | ||
| nav#aboutSidebar h1 { | ||
| display: none; |
There was a problem hiding this comment.
i can't understand it. most of the times when we have display none, i think it's self evident (like hebrew/english staff). here i ask myself why we have it if it isn't displayed.
There was a problem hiding this comment.
It's a good question. The CSS could be clearer but I'm not sure the best way. The header in question only appears on the mobile about menu page.
There was a problem hiding this comment.
so maybe it should have a class only-mobile or so?
Description
Move position of title for all super about pages.
Code Changes
Notes
Perhaps the mobileAboutHeader should be re-named to aboutHeader since it now shows both on mobile and desktop. What do you think?