Feature/sc 27331/new sidebar component2 #2163
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/sc-27331/new-sidebar-component
…/sc-27331/new-sidebar-component
…c-27331/new-sidebar-component
…/sc-27331/new-sidebar-component
…/sc-27331/new-sidebar-component
…/sc-27331/new-sidebar-component
…et outerStyle in JS
…w-sidebar-component
…w-sidebar-component
…w-sidebar-component
…w-sidebar-component
…w-sidebar-component
…w-sidebar-component
…sc-27313/remove-resources-panel
…c-27320/remove-reader-header-bar
…w-sidebar-component
yitzhakc
requested changes
Dec 15, 2024
chore: break down ProfileSummary into logical components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The core of this PR is the SheetContentSidebar component which is used by the Sheets Viewer and will eventually be used by the Sheets Editor as well. It displays profile information, a profile picture, a follow button, and a list of the sheet maker's collections that the sheet is in.
Code Changes
The SheetContentSidebar works by loading the profile data through Sefaria.profileAPI and then passing the profile object to a new component SheetProfileInfo, which uses the profile data to display the user's education, location, organization, and followers information. Modification was made to UserBackground so that it properly displays the HTML of the profile bio ("about me"). The profile bio is the only part of the profile that is in HTML, which I did not realize, so that I previously rendered everything in UserBackground as plain text. Finally, a new component SheetCollectionsList displays the collections that the sheet maker put the sheet in.