Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sc 30090/confirm rtl changes still work in new sheets #2201

Conversation

stevekaplan123
Copy link
Contributor

Description

Merged rtl-client into modularization-main and made changes to DropdownMenu.jsx and s2.css so that both types of dropdown menu work.

Code Changes

Change name of props of buttonContent and menuIconComponent to buttonComponent both in and in all instances of it
Change .buttonClosest into a data attribute data-prevent-close="true"
CSS resolutions
dropdownButton needs to be resolved to dropdownLinks-button (note that it was changed from a button html element to an a)
Note that in rtl-client {children} is directly inside div.dropdownLinks-menu whereas in modularization-main it's enclosed within an additional div.dropdownLinks-options
We've removed the additional enclosing div from modularization main
No default export when importing DropdownMenu.jsx
An additional enclosing div (or component?) should be added to the instances of in the Header.jsx
The instances of in rtl-client are all enclosed with divs that set the positioning style
The CSS styling used in .header .dropdownLinks should be migrated to a class that the newly created enclosing div/component (used in Header.jsx) will be tagged with
The CSS styling on should be as sparse as possible
Add an additional prop to called positioningClass that will be added to the list of class -es in the "first"

in DropdownMenu and is in charge of the positioning styling of the open menu location
I.e. in rtl instances use dropdownMenu and in Header.jsx use dropdownLinks -- CHANGE ALL THESE CLASS NAMES (readerDropdownMenu vs headerDropdownMenu)
Now that we've removed the
from the DropdownMenu component, we need to prepend the children passed in to instances in Header.jsx with a
to properly position the children.
in rtl instances this is already taken care of

…g them to fit the expected old api response.
… to include an object for any language (he and en) rather than a string. The idea is to enable it to include other details and not only versionTitle.
…mbers and use it rather than placeSegmentNuncers.
…o components (rather than get it from cache objects).
YishaiGlasner and others added 19 commits December 2, 2024 13:34
…as languageFamilyName. this enables finding versions when we have only versionTitle without languageFamilyName (this happens in search results).
…s API accurately - with he/en meaning primary/translation and with the languageFamilyName param.
…with useEffect. control closing when clicking inside menu by adding a classname for preventing closing
feat(elasticSearch): add languageFamilyName and isPrimary to search API result.
…HigherPriority in reduce call, for higher readability.
static/js/common/DropdownMenu.jsx Outdated Show resolved Hide resolved
static/js/common/DropdownMenu.jsx Outdated Show resolved Hide resolved
@yitzhakc yitzhakc merged commit 9872d7e into modularization-main Jan 6, 2025
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants