[Sheets] Saved, History and Notes #2203
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creating the "sheets" side of Saved, History and Notes.
Code Changes
reader/views.py- Shiftpageto match the expandedmenuOpenoptions (texts-saved,sheets-saved,texts-history,sheets-history,notes).sefaria/urls.py- Add new URLs for sheetsstatic/js/ReaderApp.jsx- URL changes and handling on the FEstatic/js/ReaderPanel.jsx- Using sheets and library wrapper classesstatic/js/UserHistoryPanel.jsx- Bulk of changes: (a) defining wrapper components withdataSourceprop, adjustingUserHistoryPanelandUserHistoryListto filter contents based on "mode" (i.e. only display saved sheets in sheets mode, and only saved refs in library mode).Notes
There are two known bugs that still need to be resolved, why this is a draft PR. Bugs are detailed on card.