Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Topic Category List and A-Z Topics Link to Sidebar #2243

Merged
merged 7 commits into from
Jan 14, 2025
Merged

Add Topic Category List and A-Z Topics Link to Sidebar #2243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0ffdb0b
fear(topic landing sidebar): topic toc component
yonadavGit Jan 12, 2025
303b86b
fear(topic landing sidebar): aztopics button
yonadavGit Jan 12, 2025
aedee85
feat(topic landing sidebar): remove pinning of google-analytics to ci…
yonadavGit Jan 12, 2025
531bab8
fix(pip requirements): pin google-analytics-data to a lower version
yonadavGit Jan 12, 2025
514308d
fix(topic landing sidebar): link categories to category pages
yonadavGit Jan 12, 2025
dbef731
feat(topic landing sidebar): style sidebar list of links
yonadavGit Jan 14, 2025
8f847fc
chore(topic landing sidebar): decrease line-height
yonadavGit Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions static/css/s2.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4954,6 +4954,11 @@ h1.topic-landing-header {
.topic-landing-search-suggestion.highlighted{
background-color: #EDEDEC;
}
.topic-landing-sidebar-list{
font-size: 18px;
font-weight: 400;
line-height: 20px
}

.topic-landing-search-dropdown{
background: #FFFFFF;
Expand Down
28 changes: 28 additions & 0 deletions static/js/NavSidebar.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ const SidebarModules = ({type, props}) => {
"AboutTopics": AboutTopics,
"TrendingTopics": TrendingTopics,
"TopicLandingTrendingTopics": TopicLandingTrendingTopics,
"TopicLandingTopicCatList": TopicLandingTopicCatList,
"AZTopicsLink": AZTopicsLink,
"RelatedTopics": RelatedTopics,
"TitledText": TitledText,
"Visualizations": Visualizations,
Expand Down Expand Up @@ -619,6 +621,7 @@ const TopicLandingTrendingTopics = () => {
<div data-anl-feature_name="Trending" data-anl-link_type="topic">
<SidebarModule>
<SidebarModuleTitle>Trending Topics</SidebarModuleTitle>
<div className="topic-landing-sidebar-list">
{trendingTopics.map((topic, i) =>
<div className="navSidebarLink ref serif" key={i}>
<a
Expand All @@ -630,9 +633,34 @@ const TopicLandingTrendingTopics = () => {
</a>
</div>
)}
</div>
</SidebarModule>
</div>)
};
const TopicLandingTopicCatList = () => {
const topicCats = Sefaria.topicTocPage();
return(
<SidebarModule>
<SidebarModuleTitle>Browse Topics</SidebarModuleTitle>
<div className="topic-landing-sidebar-list">
{topicCats.map((topic, i) =>
<div className="navSidebarLink ref serif" key={i}>
<a href={"/topics/category/" + topic.slug}><InterfaceText text={{en: topic.en, he: topic.he}}/></a>
</div>
)}
</div>
</SidebarModule>
)
};
const AZTopicsLink = () => {
return (
<SidebarModule>
<a href={'/topics/all/a'}>
<SidebarModuleTitle>All Topics A-Z ›</SidebarModuleTitle>
</a>
</SidebarModule>
)
};


const RelatedTopics = ({title}) => {
Expand Down
4 changes: 3 additions & 1 deletion static/js/TopicLandingPage/TopicsLandingPage.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@ import Sefaria from "../sefaria/sefaria";

export const TopicsLandingPage = ({openTopic}) => {
const sidebarModules = [
{type: "TopicLandingTrendingTopics"}
{type: "TopicLandingTopicCatList"},
{type: "TopicLandingTrendingTopics"},
{type: "AZTopicsLink"},
];
return (
<div className="readerNavMenu" key="0">
Expand Down
Loading