Rtl cache ssr #2247
Merged
Rtl cache ssr #2247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akiva10b
commented
Jan 13, 2025
| let settings = {context: 1, enVersion: panel.enVersion, heVersion: panel.heVersion}; | ||
| //save versions first, so their new format is also saved on text cache | ||
| if(panel.text?.versions?.length){ | ||
| let versions = Sefaria._saveVersions(panel.text.sectionRef, panel.text.available_versions); | ||
| let versions = Sefaria._saveVersions(panel.text.sectionRef, panel.text.versions); |
There was a problem hiding this comment.
@YishaiGlasner please verify that this is a correct change
| const mergeTextInt = mergeText ? 1 : 0; | ||
| const return_format_string = (return_format) ? `&return_format=${return_format}` : ''; | ||
| const encodedRef = Sefaria.normRef(ref); | ||
| const url = `${host}${endPoint}${encodedRef}?version=${versions.join('&version=')}&fill_in_missing_segments=${mergeTextInt}${return_format_string}`; | ||
| return url; | ||
| }, | ||
| _textsStore: {}, | ||
| _textsStoreSet: function(key, value) { |
There was a problem hiding this comment.
doc string to explain why we have 2 caches?
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A brief description of the PR
Code Changes
The following changes were made to the files below
Notes
Any additional notes go here