-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#91 Xvfb failed to start fix #256
#91 Xvfb failed to start fix #256
Conversation
"seluser" and not as root due to which the entrypoint script fails. Only impacts all debug node containers
Works for me! :D |
Worked for me as well |
I need this too. |
@kayabendroth can this be merged |
@kayabendroth merge this please |
@kayabendroth is it possible to merge this PR? |
Ping... |
could you please rebase your branch? then i'll merge it in |
//summon @gurukiran007 |
Conflicts: NodeChromeDebug/Dockerfile NodeFirefoxDebug/Dockerfile StandaloneChromeDebug/Dockerfile StandaloneFirefoxDebug/Dockerfile
Done can you guys see if this helps now... |
@gurukiran007 I tried docker run -P -p 5901:5901 -e no_proxy=localhost -e HUB_ENV_no_proxy=localhost --link selenium-hub:hub selenium/node-chrome-debug:2.53.1 and got error Unable to find image 'selenium/node-chrome-debug:2.53.1' locally |
@vikramvi does that work on master for you ? |
@gurukiran007 can you please give command which I can try , struggling with debug version since almost 1/2 day now :( thanks in advance. |
@vikramvi : @ddavison can you please merge this to master. I have rebased the branch from master. |
@kayabendroth can you help please i cannot understand why the build fails after i have rebased from master |
@gurukiran007 From the logs it looks to me like I'd also expect to see the echo output from https://github.com/gurukiran007/docker-selenium/blob/89a6026d5191bab02c1e254bff44c251724c373e/test.sh#L22 in the logs?! |
yea - i've been fiddling around with it trying to get it to work to no avail.. i'm very tempted to wipe it out and try something with travis |
good news! i've got travis integration working. i'll be working on implementing this, then working on getting this in |
do me a favor @gurukiran007 and push another commit.. your build should pass when run through travis. (gotta invoke it first with a commit) |
Adding just a space to commit and trigger the build
one more test, then this puppy is going in. give me a little |
Sounds good thanks @ddavison |
@gurukiran007 , are you able to successfully run your NodeChromeDebug container? i see that it's done waiting for xvfb, but fails on Xserver stuff, ultimately killing the container
|
Let me re test it locally ... that does not look right ... |
were you able to find out the issue? the chrome-debug image is still unstable for some reason.. i haven't been able to narrow it down just yet |
i found the issue - it's due to this issue in docker that i was unable to build successfully. |
Thanks @ddavison for closing that and sharing the docker bug.. the explains the local issue i had as well.. 👍 |
sorry i couldn't give your commit credit there.. i did pull pieces of yours in to use, but i'm trying to organize everything in the repository.. merging it in from github would've been uncomfortable as it is right now.. it'll be stable shortly, where i can accept PR's from github 😊 |
wait, @gurukiran007 - what were we thinking.. the entry_point.sh is called by root, NOT seluser. the xvfb-run command is executed by seluser, not root. and the x11vnc command is run by a lot of people said this works for them, but it makes no sense why it does. i just took a look at #291 and this happens when .vnc/ is in /home/seluser, but passes when in /root/.vnc. |
@ddavison I see what you mean, The defect it fixed was that the docker file created the password with root: http://screencast.com/t/DIIpZvARg |
well, i have #292 working right now, so i think i'll merge that in. I don't believe it matters who is running x11vnc |
Ok, but i believe that fix will again not allow the VNC server to be up as |
The fix is to make sure that the password used by VNC is created by "seluser" and not as root due to which the entrypoint script fails. Only
impacts all debug node containers
This must fix issues i guess:
#91
#205
#76
#257
#253