Skip to content

Commit

Permalink
[bazel]: Prepare for bump of rules_closure (#14890)
Browse files Browse the repository at this point in the history
Future updates to `rules_closure` remove the handy `closure/library`
target we depend on. Use exact deps instead.
  • Loading branch information
shs96c authored Dec 12, 2024
1 parent 7cde7f8 commit 2cc530d
Show file tree
Hide file tree
Showing 8 changed files with 90 additions and 27 deletions.
73 changes: 60 additions & 13 deletions javascript/atoms/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,11 @@ closure_js_library(
":dom",
":errors",
":events",
"@io_bazel_rules_closure//closure/library",
"@io_bazel_rules_closure//closure/library/array",
"@io_bazel_rules_closure//closure/library/dom:tagname",
"@io_bazel_rules_closure//closure/library/math:coordinate",
"@io_bazel_rules_closure//closure/library/math:vec2",
"@io_bazel_rules_closure//closure/library/style",
],
)

Expand All @@ -59,7 +63,8 @@ closure_js_library(
"JSC_USE_OF_GOOG_PROVIDE",
],
deps = [
"@io_bazel_rules_closure//closure/library",
"@io_bazel_rules_closure//closure/library/array",
"@io_bazel_rules_closure//closure/library/color:names",
],
)

Expand All @@ -86,7 +91,15 @@ closure_js_library(
":events",
":locators",
":useragent",
"@io_bazel_rules_closure//closure/library",
"@io_bazel_rules_closure//closure/library/array",
"@io_bazel_rules_closure//closure/library/dom",
"@io_bazel_rules_closure//closure/library/dom:selection",
"@io_bazel_rules_closure//closure/library/dom:tagname",
"@io_bazel_rules_closure//closure/library/math:coordinate",
"@io_bazel_rules_closure//closure/library/structs:map",
"@io_bazel_rules_closure//closure/library/structs:set",
"@io_bazel_rules_closure//closure/library/useragent",
"@io_bazel_rules_closure//closure/library/useragent:product",
],
)

Expand All @@ -102,7 +115,10 @@ closure_js_library(
deps = [
":errors",
":useragent",
"@io_bazel_rules_closure//closure/library",
"@io_bazel_rules_closure//closure/library/array",
"@io_bazel_rules_closure//closure/library/dom",
"@io_bazel_rules_closure//closure/library/dom:nodetype",
"@io_bazel_rules_closure//closure/library/dom:tagname",
],
)

Expand All @@ -123,7 +139,16 @@ closure_js_library(
":domcore",
":json",
":useragent",
"@io_bazel_rules_closure//closure/library",
"@io_bazel_rules_closure//closure/library/array",
"@io_bazel_rules_closure//closure/library/dom",
"@io_bazel_rules_closure//closure/library/dom:nodetype",
"@io_bazel_rules_closure//closure/library/dom:tagname",
"@io_bazel_rules_closure//closure/library/math",
"@io_bazel_rules_closure//closure/library/math:coordinate",
"@io_bazel_rules_closure//closure/library/math:rect",
"@io_bazel_rules_closure//closure/library/string",
"@io_bazel_rules_closure//closure/library/style",
"@io_bazel_rules_closure//closure/library/useragent",
],
)

Expand Down Expand Up @@ -158,7 +183,12 @@ closure_js_library(
":errors",
":json",
":useragent",
"@io_bazel_rules_closure//closure/library",
"@io_bazel_rules_closure//closure/library/array",
"@io_bazel_rules_closure//closure/library/dom",
"@io_bazel_rules_closure//closure/library/events:browserevent",
"@io_bazel_rules_closure//closure/library/style",
"@io_bazel_rules_closure//closure/library/useragent",
"@io_bazel_rules_closure//closure/library/useragent:product",
],
)

Expand All @@ -179,7 +209,8 @@ closure_js_library(
":dom",
":errors",
":locators",
"@io_bazel_rules_closure//closure/library",
"@io_bazel_rules_closure//closure/library/dom",
"@io_bazel_rules_closure//closure/library/dom:tagname",
],
)

Expand Down Expand Up @@ -219,7 +250,10 @@ closure_js_library(
":bot",
":errors",
":json",
"@io_bazel_rules_closure//closure/library",
"@io_bazel_rules_closure//closure/library/array",
"@io_bazel_rules_closure//closure/library/dom:nodetype",
"@io_bazel_rules_closure//closure/library/object",
"@io_bazel_rules_closure//closure/library/useragent",
],
)

Expand All @@ -231,7 +265,8 @@ closure_js_library(
],
deps = [
":useragent",
"@io_bazel_rules_closure//closure/library",
"@io_bazel_rules_closure//closure/library/json",
"@io_bazel_rules_closure//closure/library/useragent",
],
)

Expand All @@ -256,7 +291,13 @@ closure_js_library(
":json",
":useragent",
"//third_party/js/wgxpath",
"@io_bazel_rules_closure//closure/library",
"@io_bazel_rules_closure//closure/library/array",
"@io_bazel_rules_closure//closure/library/dom",
"@io_bazel_rules_closure//closure/library/dom:nodetype",
"@io_bazel_rules_closure//closure/library/math:rect",
"@io_bazel_rules_closure//closure/library/string",
"@io_bazel_rules_closure//closure/library/useragent",
"@io_bazel_rules_closure//closure/library/useragent:product",
],
)

Expand All @@ -268,7 +309,12 @@ closure_js_library(
"JSC_UNKNOWN_EXPR_TYPE",
"JSC_USE_OF_GOOG_PROVIDE",
],
deps = ["@io_bazel_rules_closure//closure/library"],
deps = [
"@io_bazel_rules_closure//closure/library/string",
"@io_bazel_rules_closure//closure/library/useragent",
"@io_bazel_rules_closure//closure/library/useragent:product",
"@io_bazel_rules_closure//closure/library/useragent:product_isversion",
],
)

closure_js_library(
Expand Down Expand Up @@ -302,7 +348,9 @@ closure_js_library(
":bot",
":errors",
":useragent",
"@io_bazel_rules_closure//closure/library",
"@io_bazel_rules_closure//closure/library/dom:nodetype",
"@io_bazel_rules_closure//closure/library/string",
"@io_bazel_rules_closure//closure/library/useragent",
],
)

Expand All @@ -315,7 +363,6 @@ closure_js_library(
],
deps = [
":useragent",
"@io_bazel_rules_closure//closure/library",
],
)

Expand Down
2 changes: 1 addition & 1 deletion javascript/atoms/fragments/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ closure_fragment(
"//javascript/chrome-driver:__pkg__",
],
deps = [
"@io_bazel_rules_closure//closure/library",
"@io_bazel_rules_closure//closure/library/style",
],
)

Expand Down
12 changes: 9 additions & 3 deletions javascript/chrome-driver/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@ closure_js_library(
deps = [
"//javascript/atoms:dom",
"//javascript/atoms:locators",
"@io_bazel_rules_closure//closure/library",
"@io_bazel_rules_closure//closure/library/dom",
"@io_bazel_rules_closure//closure/library/math:coordinate",
"@io_bazel_rules_closure//closure/library/math:rect",
"@io_bazel_rules_closure//closure/library/math:size",
"@io_bazel_rules_closure//closure/library/style",
],
)

Expand All @@ -24,7 +28,9 @@ closure_fragment(
browsers = ["chrome"],
function = "goog.style.getPageOffset",
module = "goog.style",
deps = ["@io_bazel_rules_closure//closure/library"],
deps = [
"@io_bazel_rules_closure//closure/library/style",
],
)

closure_fragment(
Expand Down Expand Up @@ -135,7 +141,7 @@ closure_js_library(
testonly = 1,
srcs = glob(["**/*.js"]),
visibility = ["//javascript:__pkg__"],
deps = ["@io_bazel_rules_closure//closure/library"],
deps = [],
)

filegroup(
Expand Down
3 changes: 2 additions & 1 deletion javascript/ie-driver/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ closure_js_library(
"//javascript/atoms:errors",
"//javascript/atoms:locators",
"//javascript/atoms:useragent",
"@io_bazel_rules_closure//closure/library",
"@io_bazel_rules_closure//closure/library/math:coordinate",
"@io_bazel_rules_closure//closure/library/style",
],
)

Expand Down
3 changes: 1 addition & 2 deletions javascript/webdriver/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ closure_js_library(
visibility = ["//javascript/remote:__pkg__"],
deps = [
"//javascript/atoms:errors",
"@io_bazel_rules_closure//closure/library",
],
)

Expand All @@ -41,7 +40,7 @@ closure_js_library(
"JSC_USE_OF_GOOG_PROVIDE",
],
visibility = ["//javascript:__pkg__"],
deps = ["@io_bazel_rules_closure//closure/library"],
deps = [],
)

filegroup(
Expand Down
10 changes: 7 additions & 3 deletions javascript/webdriver/atoms/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,11 @@ closure_js_library(
"//javascript/atoms:domcore",
"//javascript/atoms:html5",
"//javascript/webdriver:key",
"@io_bazel_rules_closure//closure/library",
"@io_bazel_rules_closure//closure/library/array",
"@io_bazel_rules_closure//closure/library/dom",
"@io_bazel_rules_closure//closure/library/dom:tagname",
"@io_bazel_rules_closure//closure/library/math:coordinate",
"@io_bazel_rules_closure//closure/library/style",
],
)

Expand All @@ -51,7 +55,8 @@ closure_js_library(
visibility = ["//visibility:private"],
deps = [
"//javascript/atoms:domcore",
"@io_bazel_rules_closure//closure/library",
"@io_bazel_rules_closure//closure/library/array",
"@io_bazel_rules_closure//closure/library/dom:tagname",
],
)

Expand Down Expand Up @@ -295,6 +300,5 @@ closure_js_library(
"//javascript/webdriver:__pkg__",
],
deps = [
"@io_bazel_rules_closure//closure/library",
],
)
6 changes: 3 additions & 3 deletions javascript/webdriver/atoms/inject/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ closure_js_library(
"//javascript/atoms:action",
"//javascript/atoms:inject",
"//javascript/webdriver/atoms:atoms-lib",
"@io_bazel_rules_closure//closure/library",
"@io_bazel_rules_closure//closure/library/json",
],
)

Expand Down Expand Up @@ -68,7 +68,7 @@ closure_js_library(
"//javascript/atoms:inject",
"//javascript/atoms:useragent",
"//javascript/webdriver/atoms:atoms-lib",
"@io_bazel_rules_closure//closure/library",
"@io_bazel_rules_closure//closure/library/json",
],
)

Expand Down Expand Up @@ -97,7 +97,7 @@ closure_js_library(
":execute-script",
"//javascript/atoms:inject",
"//javascript/atoms:locators",
"@io_bazel_rules_closure//closure/library",
"@io_bazel_rules_closure//closure/library/json",
],
)

Expand Down
8 changes: 7 additions & 1 deletion third_party/js/wgxpath/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,11 @@ closure_js_library(
"JSC_USE_OF_GOOG_PROVIDE",
],
visibility = ["//visibility:public"],
deps = ["@io_bazel_rules_closure//closure/library"],
deps = [
"@io_bazel_rules_closure//closure/library/array",
"@io_bazel_rules_closure//closure/library/dom",
"@io_bazel_rules_closure//closure/library/dom:nodetype",
"@io_bazel_rules_closure//closure/library/string",
"@io_bazel_rules_closure//closure/library/useragent",
],
)

0 comments on commit 2cc530d

Please sign in to comment.