Remove hard-coded ports from tests

SeleniumHQ · Sep 28, 2021 · b6ce2cf · b6ce2cf
1 parent ddfcd94
commit b6ce2cf
Show file tree

Hide file tree

Showing 3 changed files with 155 additions and 194 deletions.
diff --git a/java/test/org/openqa/selenium/firefox/BUILD.bazel b/java/test/org/openqa/selenium/firefox/BUILD.bazel
@@ -8,12 +8,16 @@ LARGE_TESTS = [
     "TakesFullPageScreenshotTest.java",
 ]
 
+REMOTE_TESTS = [
+    "RemoteFirefoxDriverTest.java",
+]
+
 java_test_suite(
     name = "small-tests",
     size = "small",
     srcs = glob(
         ["*.java"],
-        exclude = LARGE_TESTS,
+        exclude = LARGE_TESTS + REMOTE_TESTS,
     ),
     data = [
         ":firebug_xpi",
@@ -69,6 +73,39 @@ java_selenium_test_suite(
     ],
 )
 
+java_selenium_test_suite(
+    name = "remote-tests",
+    size = "large",
+    srcs = REMOTE_TESTS,
+    browsers = [
+        "firefox",
+    ],
+    data = [
+        "//third_party/firebug:favourite_colour-1.1-an+fx.xpi",
+        "//third_party/firebug:firebug-1.5.0-fx.xpi",
+        "//third_party/firebug:mooltipass-1.1.87.xpi",
+    ],
+    resources = [
+        "//third_party/firebug:favourite_colour-1.1-an+fx.xpi",
+        "//third_party/firebug:firebug-1.5.0-fx.xpi",
+        "//third_party/firebug:mooltipass-1.1.87.xpi",
+    ],
+    tags = [
+        "selenium-remote",
+    ],
+    deps = [
+        "//java/src/org/openqa/selenium/firefox",
+        "//java/src/org/openqa/selenium/remote",
+        "//java/test/org/openqa/selenium/build",
+        "//java/test/org/openqa/selenium/testing:annotations",
+        "//java/test/org/openqa/selenium/testing:test-base",
+        "//java/test/org/openqa/selenium/testing/drivers",
+        artifact("junit:junit"),
+        artifact("org.assertj:assertj-core"),
+    ],
+)
+
+
 copy_file(
     name = "firebug_xpi",
     src = "//third_party/firebug:firebug-1.5.0-fx.xpi",