Skip to content

Commit

Permalink
Updating .NET strong-named assembly build to correct package references
Browse files Browse the repository at this point in the history
Fixes issue #5511.
  • Loading branch information
jimevans committed Mar 12, 2018
1 parent 7dff24f commit d37967a
Show file tree
Hide file tree
Showing 6 changed files with 145 additions and 3 deletions.
2 changes: 1 addition & 1 deletion dotnet/src/support/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ genrule(

genrule(
name = 'pack_strongnamed',
srcs = ['WebDriver.Support.nuspec'],
srcs = ['WebDriver.Support.StrongNamed.nuspec'],
cmd_exe = "$(exe //third_party/dotnet/nuget:nuget) pack %SRCS% /Properties packageid=Selenium.Support.StrongNamed;version={} /Version {} /BasePath $(location :merge_strongnamed) /OutputDirectory %OUT%".format(SE_VERSION, SE_VERSION),
out = 'dist',
visibility = [ 'PUBLIC' ]
Expand Down
48 changes: 48 additions & 0 deletions dotnet/src/support/WebDriver.Support.StrongNamed.nuspec
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
<?xml version="1.0" encoding="utf-8"?>
<package xmlns="http://schemas.microsoft.com/packaging/2012/06/nuspec.xsd">
<metadata>
<id>$packageid$</id>
<version>$version$</version>
<authors>Selenium Committers</authors>
<copyright>Copyright © 2018 Software Freedom Conservancy</copyright>
<owners>selenium</owners>
<title>WebDriver Support</title>
<requireLicenseAcceptance>false</requireLicenseAcceptance>
<summary>Provides support classes for Selenium WebDriver</summary>
<description>
Selenium is a set of different software tools each with a different approach
to supporting browser automation. These tools are highly flexible, allowing
many options for locating and manipulating elements within a browser, and one
of its key features is the support for automating multiple browser platforms.
This package contains .NET support utilites and classes that users may find
useful in using Selenium WebDriver. These support classes are mainly intended
to spark ideas of what is possible with Selenium WebDriver, and may not be
entirely appropriate for production use.
</description>
<projectUrl>https://www.seleniumhq.org</projectUrl>
<repository url="https://github.com/SeleniumHQ/selenium" />
<licenseUrl>http://www.apache.org/licenses/LICENSE-2.0</licenseUrl>
<iconUrl>http://seleniumhq.org/images/big-logo.png</iconUrl>
<tags>selenium webdriver support browser automation</tags>
<dependencies>
<group targetFramework=".NETFramework3.5">
<dependency id="Selenium.WebDriver.StrongNamed" version="$version$" exclude="Build,Analyzers" />
</group>
<group targetFramework=".NETFramework4.0">
<dependency id="Selenium.WebDriver.StrongNamed" version="$version$" exclude="Build,Analyzers" />
</group>
<group targetFramework=".NETFramework4.5">
<dependency id="Selenium.WebDriver.StrongNamed" version="$version$" exclude="Build,Analyzers" />
</group>
<group targetFramework=".NETStandard2.0">
<dependency id="Selenium.WebDriver.StrongNamed" version="$version$" exclude="Build,Analyzers" />
</group>
</dependencies>
<frameworkAssemblies>
<frameworkAssembly assemblyName="System.Drawing" />
</frameworkAssemblies>
</metadata>
<files>
<file src="**" target="lib" />
</files>
</package>
2 changes: 1 addition & 1 deletion dotnet/src/webdriver/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ genrule(

genrule(
name = 'pack_strongnamed',
srcs = ['WebDriver.nuspec'],
srcs = ['WebDriver.StrongNamed.nuspec'],
cmd_exe = "$(exe //third_party/dotnet/nuget:nuget) pack %SRCS% /Properties packageid=Selenium.WebDriver.StrongNamed /Version {} /BasePath $(location :merge_strongnamed) /OutputDirectory %OUT%".format(SE_VERSION),
out = 'dist',
visibility = [ 'PUBLIC' ]
Expand Down
42 changes: 42 additions & 0 deletions dotnet/src/webdriver/WebDriver.StrongNamed.nuspec
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
<?xml version="1.0" encoding="utf-8"?>
<package xmlns="http://schemas.microsoft.com/packaging/2012/06/nuspec.xsd">
<metadata>
<id>$packageid$</id>
<version>$version$</version>
<authors>Selenium Committers</authors>
<copyright>Copyright © 2018 Software Freedom Conservancy</copyright>
<owners>selenium</owners>
<title>Selenium WebDriver</title>
<requireLicenseAcceptance>false</requireLicenseAcceptance>
<summary>.NET bindings for the Selenium WebDriver API</summary>
<description>
Selenium is a set of different software tools each with a different approach
to supporting browser automation. These tools are highly flexible, allowing
many options for locating and manipulating elements within a browser, and one
of its key features is the support for automating multiple browser platforms.
This package contains the .NET bindings for the concise and object-based
Selenium WebDriver API, which uses native OS-level events to manipulate the
browser, bypassing the JavaScript sandbox, and does not require the Selenium
Server to automate the browser.
</description>
<projectUrl>https://www.seleniumhq.org</projectUrl>
<repository url="https://github.com/SeleniumHQ/selenium" />
<licenseUrl>http://www.apache.org/licenses/LICENSE-2.0</licenseUrl>
<iconUrl>http://seleniumhq.org/images/big-logo.png</iconUrl>
<tags>selenium webdriver browser automation</tags>
<dependencies>
<group targetFramework=".NETFramework3.5" />
<group targetFramework=".NETFramework4.0" />
<group targetFramework=".NETFramework4.5" />
<group targetFramework=".NETStandard2.0">
<dependency id="Newtonsoft.Json" version="10.0.3" exclude="Build,Analyzers" />
</group>
</dependencies>
<frameworkAssemblies>
<frameworkAssembly assemblyName="System.Drawing" />
</frameworkAssemblies>
</metadata>
<files>
<file src="**" target="lib" />
</files>
</package>
2 changes: 1 addition & 1 deletion dotnet/src/webdriverbackedselenium/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ genrule(

genrule(
name = 'pack_strongnamed',
srcs = ['Selenium.WebDriverBackedSelenium.nuspec'],
srcs = ['Selenium.WebDriverBackedSelenium.StrongNamed.nuspec'],
cmd_exe = "$(exe //third_party/dotnet/nuget:nuget) pack %SRCS% /Properties packageid=Selenium.WebDriverBackedSelenium.StrongNamed;version={} /Version {} /BasePath $(location :merge_strongnamed) /OutputDirectory %OUT%".format(SE_VERSION, SE_VERSION),
out = 'dist',
visibility = [ 'PUBLIC' ]
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
<?xml version="1.0" encoding="utf-8"?>
<package xmlns="http://schemas.microsoft.com/packaging/2012/06/nuspec.xsd">
<metadata>
<id>$packageid$</id>
<version>$version$</version>
<authors>Selenium Committers</authors>
<copyright>Copyright © 2017 Software Freedom Conservancy</copyright>
<owners>selenium</owners>
<title>WebDriver-backed Selenium</title>
<requireLicenseAcceptance>false</requireLicenseAcceptance>
<summary>Implementation of the Selenium Remote Control (RC) API, using WebDriver technology</summary>
<description>
Selenium is a set of different software tools each with a different approach
to supporting browser automation. These tools are highly flexible, allowing
many options for locating and manipulating elements within a browser, and one
of its key features is the support for automating multiple browser platforms.
This package contains the .NET bindings for the deprecated, more procedural
Selenium Remote Control (or Selenium RC) API, but implemented using the current
WebDriver technology. It does not require a running instance of the Selenium
Server, and is not limited to the functionality available from within the
JavaScript sandbox. It is intended as a transitional package to allow
organizations with significant investment in the Selenium RC API to run their
code with minimal modifications until they are able to migrate to the Selenium
WebDriver API.
</description>
<projectUrl>https://www.seleniumhq.org</projectUrl>
<repository url="https://github.com/SeleniumHQ/selenium" />
<licenseUrl>http://www.apache.org/licenses/LICENSE-2.0</licenseUrl>
<iconUrl>http://seleniumhq.org/images/big-logo.png</iconUrl>
<tags>selenium webdriver remote control rc browser automation</tags>
<dependencies>
<group targetFramework=".NETFramework3.5">
<dependency id="Selenium.WebDriver.StrongNamed" version="$version$" exclude="Build,Analyzers" />
</group>
<group targetFramework=".NETFramework4.0">
<dependency id="Selenium.WebDriver.StrongNamed" version="$version$" exclude="Build,Analyzers" />
</group>
<group targetFramework=".NETFramework4.5">
<dependency id="Selenium.WebDriver.StrongNamed" version="$version$" exclude="Build,Analyzers" />
</group>
<group targetFramework=".NETStandard2.0">
<dependency id="Selenium.WebDriver.StrongNamed" version="$version$" exclude="Build,Analyzers" />
</group>
</dependencies>
<frameworkAssemblies>
<frameworkAssembly assemblyName="System.Drawing" />
</frameworkAssemblies>
</metadata>
<files>
<file src="**" target="lib" />
</files>
</package>

0 comments on commit d37967a

Please sign in to comment.