Skip to content

Commit

Permalink
[dotnet] Address warnings for Firefox devtool depreciations (#14786)
Browse files Browse the repository at this point in the history
  • Loading branch information
RenderMichael authored Nov 21, 2024
1 parent 0954cca commit e2b33c6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions dotnet/src/webdriver/Firefox/FirefoxDriver.cs
Original file line number Diff line number Diff line change
Expand Up @@ -393,6 +393,7 @@ public Screenshot GetFullPageScreenshot()
/// Creates a session to communicate with a browser using the Chromium Developer Tools debugging protocol.
/// </summary>
/// <returns>The active session to use to communicate with the Chromium Developer Tools debugging protocol.</returns>
[Obsolete("CDP support for Firefox is deprecated and will be removed in future versions. Please switch to WebDriver BiDi.")]
public DevToolsSession GetDevToolsSession()
{
return GetDevToolsSession(new DevToolsOptions() { ProtocolVersion = FirefoxDevToolsProtocolVersion });
Expand Down
2 changes: 1 addition & 1 deletion dotnet/src/webdriver/Remote/RemoteWebDriver.cs
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,7 @@ public ReadOnlyCollection<IWebElement> FindElementsByCssSelector(string cssSelec
/// <returns>The active session to use to communicate with the Developer Tools debugging protocol.</returns>
public DevToolsSession GetDevToolsSession()
{
if (this.Capabilities.GetCapability(CapabilityType.BrowserName) == "firefox")
if (this.Capabilities.GetCapability(CapabilityType.BrowserName) is "firefox")
{
if (_logger.IsEnabled(LogEventLevel.Warn))
{
Expand Down

0 comments on commit e2b33c6

Please sign in to comment.