Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_implicit_wait #7738

Closed
snoopyjc opened this issue Nov 2, 2019 · 4 comments
Closed

get_implicit_wait #7738

snoopyjc opened this issue Nov 2, 2019 · 4 comments
Labels

Comments

@snoopyjc
Copy link

snoopyjc commented Nov 2, 2019

🚀 Feature Proposal

I would like to propose a driver.get_implicit_wait() function.

Motivation

Functions shouldn't have side-effects if if I call driver.implicitly_wait(2) in my function, there is no way to set it back to what it was.

Example

def do_something():
    old_wait = driver.get_implicit_wait()
    driver.implicitly_wait(2)
    try:
        ... do stuff ...
    finally:
        driver.implicitly_wait(old_wait)
@barancev barancev added the C-py label Nov 3, 2019
@Dalvenjia
Copy link

I don't think drv.implicitly_wait is meant to be used that way, we have WebdriverWait + ExpectedConditions for that sort of things.
I think the implicit wait is for the webdriver to work correctly over slow networks, real or synthetic bandwidth throttle that take a long time to load overall

@isaulv
Copy link
Contributor

isaulv commented Jan 2, 2020

Since this is Python, write a context manager to reset your prior implicit wait.
This will not be added to the library, but if others want to add a thing under support, I am not opposed.

@snoopyjc
Copy link
Author

snoopyjc commented Feb 28, 2020 via email

@lock
Copy link

lock bot commented Apr 2, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants