Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet] Avoid potential deadlock when starting new dev tools session #12592

Merged
merged 2 commits into from
Aug 30, 2023
Merged

[dotnet] Avoid potential deadlock when starting new dev tools session #12592

merged 2 commits into from
Aug 30, 2023

Conversation

nvborisenko
Copy link
Member

@nvborisenko nvborisenko commented Aug 22, 2023

Description

There is a chance to get a deadlock when starting new cdp session.

Motivation and Context

Fixes #11703

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I have tested it locally, the issue is not reproducible anymore.

@diemol diemol added this to the 4.12 milestone Aug 25, 2023
@titusfortner
Copy link
Member

Does #12614 affect this?

@nvborisenko
Copy link
Member Author

Should not, it's still actionable.

@jimevans jimevans merged commit d38ce70 into SeleniumHQ:trunk Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: WebDriver hanging in case of DevTools opened and tests are executed in multiple thread
4 participants