Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dotnet] Remove IdentityModel nuget from bazel workspace #12834

Merged
merged 3 commits into from
Sep 29, 2023
Merged

[dotnet] Remove IdentityModel nuget from bazel workspace #12834

merged 3 commits into from
Sep 29, 2023

Conversation

nvborisenko
Copy link
Member

@nvborisenko nvborisenko commented Sep 28, 2023 •
edited
Loading

Description

We didn't clean IdentityModel dependency completely.

Motivation and Context

Fix .net CI build.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@titusfortner titusfortner merged commit 1992155 into SeleniumHQ:trunk Sep 29, 2023
11 of 13 checks passed
@nvborisenko nvborisenko deleted the dotnet-identitymodel-bazel branch September 29, 2023 12:57
aguspe pushed a commit to aguspe/selenium that referenced this pull request Oct 22, 2023
@nvborisenko @aguspe
[dotnet] Remove IdentityModel nuget from bazel workspace (SeleniumHQ#…
21023d8 
…12834)

* Remove IdentityModel from bazel workspace

* Make Base64UrlEncoder as public

* Make Base64UrlEncoder back to internal
aguspe pushed a commit to aguspe/selenium that referenced this pull request Oct 29, 2023
@nvborisenko @aguspe
[dotnet] Remove IdentityModel nuget from bazel workspace (SeleniumHQ#…
914abb6 
…12834)

* Remove IdentityModel from bazel workspace

* Make Base64UrlEncoder as public

* Make Base64UrlEncoder back to internal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nvborisenko @titusfortner