Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Delete SM binary only when SE_MANAGER_PATH is not set #12840

Merged
merged 1 commit into from
Sep 30, 2023

Conversation

bonigarcia
Copy link
Member

Description

When the SE_MANAGER_PATH env is set in Java, after using it, the SM binary is deleted by the Java wrapper. This behavior makes sense for the SM binary in the temp folder, but it should not be deleted when the user is specifying SE_MANAGER_PATH.

Motivation and Context

The SE_MANAGER_PATH env mechanism was introduced in Selenium 4.13.0.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9a6947e) 56.51% compared to head (958613c) 56.51%.
Report is 1 commits behind head on trunk.

❗ Current head 958613c differs from pull request most recent head 16236a2. Consider uploading reports for the commit 16236a2 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #12840   +/-   ##
=======================================
  Coverage   56.51%   56.51%           
=======================================
  Files          86       86           
  Lines        5255     5255           
  Branches      187      187           
=======================================
  Hits         2970     2970           
  Misses       2098     2098           
  Partials      187      187           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@titusfortner titusfortner merged commit cdcc7a1 into trunk Sep 30, 2023
46 of 60 checks passed
@titusfortner titusfortner deleted the java_fix_sm branch September 30, 2023 02:21
aguspe pushed a commit to aguspe/selenium that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants