-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new command to get HeapSnapshot for ChromeDriver. #131
Conversation
@@ -24,6 +24,7 @@ | |||
String PLATFORM = "platform"; | |||
String SUPPORTS_JAVASCRIPT = "javascriptEnabled"; | |||
String TAKES_SCREENSHOT = "takesScreenshot"; | |||
String TAKES_HEAP_SNAPSHOT = "takesHeapSnapshot"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a standard capability and should be hidden behind a vendor prefix: -chromium-takesHeapSnapshot
I'm not comfortable with extending the core Selenium API for a browser-specific feature. Can this be provided as utility library that uses WebDriver as a collaborator? Maybe something like:
|
Sorry, has this ever made it into the client API? |
@klepikov no it's not. you can do a File search by pressing |
@jleyba @gaoshuotao Is there a disagreement in principle, or is it simply a case of a stalled code review? |
@gaoshuotao, do you want to address @jleyba's issues? |
closing, PR now too old, required changes. Submit a new PR if appropriate. |
Main changes: