Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return type to webelement.submit #13490

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Add return type to webelement.submit #13490

merged 2 commits into from
Mar 26, 2024

Conversation

adamtheturtle
Copy link
Contributor

Motivation and Context

Without this, mypy in strict mode gives me the error:

Call to untyped function "submit" in typed context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Without this, `mypy` in strict mode gives me the error:

```
Call to untyped function "submit" in typed context
```
@CLAassistant
Copy link

CLAassistant commented Jan 23, 2024

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f9ff9b3) 58.48% compared to head (4b749fb) 58.57%.
Report is 10 commits behind head on trunk.

❗ Current head 4b749fb differs from pull request most recent head f1c7a38. Consider uploading reports for the commit f1c7a38 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #13490      +/-   ##
==========================================
+ Coverage   58.48%   58.57%   +0.09%     
==========================================
  Files          86       86              
  Lines        5270     5270              
  Branches      220      220              
==========================================
+ Hits         3082     3087       +5     
+ Misses       1968     1963       -5     
  Partials      220      220              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pujagani pujagani added the C-py label Feb 8, 2024
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @adamtheturtle!

@diemol diemol merged commit 4cfe983 into SeleniumHQ:trunk Mar 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants