Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet] Treat unsuccessful http responses as errored commands #13608

Merged
merged 8 commits into from
Mar 25, 2024

Conversation

nvborisenko
Copy link
Member

@nvborisenko nvborisenko commented Feb 20, 2024

Description

Currently http responses are treated as unsuccessful only based on body content. This PR verifies http status code first, avoiding a process of parsing body content.

Motivation and Context

Related to #11713, according https://www.w3.org/TR/webdriver2/#errors

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@titusfortner titusfortner merged commit 3fab5fa into SeleniumHQ:trunk Mar 25, 2024
11 checks passed
@nvborisenko nvborisenko deleted the dotnet-http-statuscode branch April 10, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants