Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] increasing of properties scope for better appium compatibility #14183

Merged
merged 9 commits into from
Oct 1, 2024
6 changes: 3 additions & 3 deletions java/src/org/openqa/selenium/remote/HttpCommandExecutor.java
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,11 @@
public class HttpCommandExecutor implements CommandExecutor, NeedsLocalLogs {

private final URL remoteServer;
private final HttpClient client;
public final HttpClient client;
private final HttpClient.Factory httpClientFactory;
private final Map<String, CommandInfo> additionalCommands;
private CommandCodec<HttpRequest> commandCodec;
private ResponseCodec<HttpResponse> responseCodec;
protected CommandCodec<HttpRequest> commandCodec;
protected ResponseCodec<HttpResponse> responseCodec;

private LocalLogs logs = LocalLogs.getNullLogger();

Expand Down
2 changes: 1 addition & 1 deletion java/src/org/openqa/selenium/remote/RemoteWebDriver.java
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ public class RemoteWebDriver
private Level level = Level.FINE;
private ErrorHandler errorHandler = new ErrorHandler();
private CommandExecutor executor;
private Capabilities capabilities;
protected Capabilities capabilities;
private SessionId sessionId;
private FileDetector fileDetector = new UselessFileDetector();
private ExecuteMethod executeMethod;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ private enum StartOrDie {
public abstract static class Builder<DS extends DriverService, B extends Builder<?, ?>> {

private int port = 0;
private File exe = null;
public File exe = null;
private Map<String, String> environment = emptyMap();
private File logFile;
private Duration timeout;
Expand Down
14 changes: 7 additions & 7 deletions java/src/org/openqa/selenium/support/ui/FluentWait.java
Original file line number Diff line number Diff line change
Expand Up @@ -66,15 +66,15 @@ public class FluentWait<T> implements Wait<T> {

private static final Duration DEFAULT_WAIT_DURATION = Duration.ofMillis(DEFAULT_SLEEP_TIMEOUT);

private final T input;
private final java.time.Clock clock;
private final Sleeper sleeper;
protected final T input;
protected final java.time.Clock clock;
protected final Sleeper sleeper;

private Duration timeout = DEFAULT_WAIT_DURATION;
private Duration interval = DEFAULT_WAIT_DURATION;
private Supplier<String> messageSupplier = () -> null;
protected Duration timeout = DEFAULT_WAIT_DURATION;
protected Duration interval = DEFAULT_WAIT_DURATION;
protected Supplier<String> messageSupplier = () -> null;

private final List<Class<? extends Throwable>> ignoredExceptions = new ArrayList<>();
protected final List<Class<? extends Throwable>> ignoredExceptions = new ArrayList<>();

/**
* @param input The input value to pass to the evaluated conditions.
Expand Down
Loading