Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace fedcm links with new ones #14478

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

navin772
Copy link
Contributor

@navin772 navin772 commented Sep 6, 2024

User description

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

The older fedidcg.github.io/FedCM links are no longer accessible, replaced them with w3c-fedid.github.io ones.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

documentation


Description

  • Updated all FedCM links from fedidcg.github.io/FedCM to w3c-fedid.github.io/FedCM across multiple files.
  • Changes affect Java, Ruby, and PDL files, ensuring documentation links are current.
  • This update is crucial for maintaining accurate references in the codebase.

Changes walkthrough 📝

Relevant files
Documentation
10 files
FederatedCredentialManagementAccount.java
Update FedCM links in FederatedCredentialManagementAccount

java/src/org/openqa/selenium/federatedcredentialmanagement/FederatedCredentialManagementAccount.java

  • Updated FedCM links to new domain.
  • Changed documentation links to w3c-fedid.github.io.
  • +4/-4     
    FederatedCredentialManagementDialog.java
    Update FedCM link in FederatedCredentialManagementDialog 

    java/src/org/openqa/selenium/federatedcredentialmanagement/FederatedCredentialManagementDialog.java

    • Updated FedCM link to new domain.
    +1/-1     
    HasFederatedCredentialManagement.java
    Update FedCM link in HasFederatedCredentialManagement       

    java/src/org/openqa/selenium/federatedcredentialmanagement/HasFederatedCredentialManagement.java

    • Updated FedCM link to new domain.
    +1/-1     
    DriverCommand.java
    Update FedCM link in DriverCommand                                             

    java/src/org/openqa/selenium/remote/DriverCommand.java

    • Updated FedCM link to new domain.
    +1/-1     
    FedCmIdAssertion.java
    Update FedCM link in FedCmIdAssertion                                       

    java/test/org/openqa/selenium/environment/webserver/FedCmIdAssertion.java

    • Updated FedCM link to new domain.
    +1/-1     
    account.rb
    Update FedCM links in Ruby Account class                                 

    rb/lib/selenium/webdriver/common/fedcm/account.rb

    • Updated FedCM links to new domain.
    +2/-2     
    browser_protocol.pdl
    Update FedCM link in Chromium v126 protocol                           

    common/devtools/chromium/v126/browser_protocol.pdl

    • Updated FedCM link to new domain.
    +1/-1     
    browser_protocol.pdl
    Update FedCM link in Chromium v127 protocol                           

    common/devtools/chromium/v127/browser_protocol.pdl

    • Updated FedCM link to new domain.
    +1/-1     
    browser_protocol.pdl
    Update FedCM link in Chromium v128 protocol                           

    common/devtools/chromium/v128/browser_protocol.pdl

    • Updated FedCM link to new domain.
    +1/-1     
    account.rbs
    Update FedCM links in Ruby Account signature                         

    rb/sig/lib/selenium/webdriver/fedcm/account.rbs

    • Updated FedCM links to new domain.
    +2/-2     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Copy link
    Contributor

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Key issues to review

    Documentation Update
    The links in the Javadoc comments have been updated to point to the new w3c-fedid.github.io domain. Ensure that these new links are correct and accessible.

    Documentation Update
    The links in the Ruby comments have been updated to point to the new w3c-fedid.github.io domain. Verify that these new links are correct and accessible.

    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Copy link
    Member

    @diemol diemol left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Thank you, @navin772!

    @diemol diemol merged commit b2ef56a into SeleniumHQ:trunk Sep 7, 2024
    1 check passed
    @navin772 navin772 deleted the replace-fedcm-links branch September 7, 2024 06:52
    @navin772
    Copy link
    Contributor Author

    navin772 commented Sep 7, 2024

    @diemol I forgot to run ./scripts/format.sh. I see that you corrected it with a commit, thank you!
    Will keep this in mind in future!

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants