-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dotnet] Add more internal logs around CDP DevTools communication #14558
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
After:
For sure user doesn't see it if he it didn't enable explicitly. |
LGTM since it is opt-in. We can always ask users to enable logging when they report issues. |
User description
Description
Just added internal logging for DevToolsSession class.
Motivation and Context
To be able analyze what is happening in CDP when users report issues related to CDP communication.
Related to #14547
Types of changes
Checklist
PR Type
enhancement, other
Description
DevToolsSession
class to trace CDP communications, improving the ability to analyze issues related to CDP.Changes walkthrough 📝
DevToolsSession.cs
Enhance CDP DevToolsSession with internal logging and error handling
dotnet/src/webdriver/DevTools/DevToolsSession.cs
ILogger
.handlers.