Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dotnet] Remove JSON serialization from .ToString() methods #14736

Merged
merged 4 commits into from
Nov 11, 2024
Merged

[dotnet] Remove JSON serialization from .ToString() methods #14736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c96813f
[dotnet] Remove JSON serialization from `riverOptions.ToString()`
RenderMichael Nov 9, 2024
e9c2117
Merge branch 'trunk' into driver-options-tostring
RenderMichael Nov 10, 2024
76f3dc5
Remove `DriverOptions.ToString()` implementation
RenderMichael Nov 10, 2024
773dd0e
Remove `ToString()` from `RemoteSessionSettings` and `ReturnedCapabil…
RenderMichael Nov 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions dotnet/src/webdriver/DriverOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
using System;
using System.Collections.Generic;
using System.Globalization;
using System.Text.Json;

namespace OpenQA.Selenium
{
Expand Down Expand Up @@ -390,15 +389,6 @@ public void SetLoggingPreference(string logType, LogLevel logLevel)
this.loggingPreferences[logType] = logLevel;
}

/// <summary>
/// Returns a string representation of this <see cref="DriverOptions"/>.
/// </summary>
/// <returns>A string representation of this <see cref="DriverOptions"/>.</returns>
public override string ToString()
{
return JsonSerializer.Serialize(this.ToDictionary(), new JsonSerializerOptions { WriteIndented = true });
}

/// <summary>
/// Returns the current options as a <see cref="Dictionary{TKey, TValue}"/>.
/// </summary>
Expand Down
10 changes: 0 additions & 10 deletions dotnet/src/webdriver/Internal/ReturnedCapabilities.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
using System.Collections.Generic;
using System.Collections.ObjectModel;
using System.Globalization;
using System.Text.Json;

namespace OpenQA.Selenium.Internal
{
Expand Down Expand Up @@ -147,14 +146,5 @@ public Dictionary<string, object> ToDictionary()
// we might want to copy/clone it instead.
return this.capabilities;
}

/// <summary>
/// Return a string of capabilities being used
/// </summary>
/// <returns>String of capabilities being used</returns>
public override string ToString()
{
return JsonSerializer.Serialize(this.capabilities, new JsonSerializerOptions { WriteIndented = true });
}
}
}
10 changes: 0 additions & 10 deletions dotnet/src/webdriver/Remote/RemoteSessionSettings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
using System;
using System.Collections.Generic;
using System.Globalization;
using System.Text.Json;

namespace OpenQA.Selenium
{
Expand Down Expand Up @@ -252,15 +251,6 @@ public Dictionary<string, object> ToDictionary()
return capabilitiesDictionary;
}

/// <summary>
/// Return a string representation of the remote session settings to be sent.
/// </summary>
/// <returns>String representation of the remote session settings to be sent.</returns>
public override string ToString()
{
return JsonSerializer.Serialize(this.ToDictionary(), new JsonSerializerOptions { WriteIndented = true });
}

internal DriverOptions GetFirstMatchDriverOptions(int firstMatchIndex)
{
if (firstMatchIndex < 0 || firstMatchIndex >= this.firstMatchOptions.Count)
Expand Down
Loading