-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[py] fix packaging #14823
[py] fix packaging #14823
Conversation
PR Code Suggestions ✨No code suggestions found for the PR. |
12be491
to
8242178
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @benoit-pierre for adding __init__.py
to fedcm.
LGTM!
@benoit-pierre can you also add the License headers to the file, it is required |
Ensure `selenium.webdriver.common.fedcm` gets packaged in.
8242178
to
0e5bc8e
Compare
@navin772, do you have any idea on how to detect this issue via test, or CI when a new package would be added in future? |
You could run tests on installed package, i.e. in Gentoo we do the equivalent of:
|
Thanks for your suggestion! |
@VietND96 we can add a pre-check in python build CI that checks recursively inside |
User description
Description
Ensure
selenium.webdriver.common.fedcm
gets packaged in.Types of changes
Checklist
PR Type
Bug fix
Description
selenium.webdriver.common.fedcm
is included in the package distribution.fedcm
module files.Changes walkthrough 📝