Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rb] Default http client use persistent connections #7065

Merged
merged 1 commit into from
Mar 29, 2019
Merged

Conversation

twalpole
Copy link
Contributor

@twalpole twalpole commented Mar 28, 2019


This change is Reviewable

@twalpole twalpole requested review from p0deje and titusfortner March 28, 2019 03:11
@twalpole
Copy link
Contributor Author

twalpole commented Mar 28, 2019

This is to start a discussion on using a persistent connection by default -- sped up Sauce over SSL by about 30% on a portion of the Capybara test suite (test suite is not necessarily typical because it does a bunch of things we specifically tell users not to)

@titusfortner
Copy link
Member

So, this should better address the issue in #5758
Also, if this works, we should probably deprecate the Remote::Http::Persistent class entirely.

I'm also really curious if Ruby is the only binding that doesn't default to keep-alive for remote connections, because if so, I'm going to need to get code out to Sauce clients on how to turn it on. :) I'll ping people on irc tomorrow.

@titusfortner
Copy link
Member

I've verified that keep alive is turned on by default for Java and .net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants