Optimized DevTools #7231
Merged
Optimized DevTools #7231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 24, 2019 12:16
optimized model parsing with Selenium Json capabilities.
adiohana
changed the title
|
Added some goodies here. |
shs96c
approved these changes
May 29, 2019
| @@ -27,31 +27,47 @@ | |||
| import java.util.StringJoiner; | |||
|
|
|||
| public class Console { | |||
| private Console() { | |||
There was a problem hiding this comment.
We want to keep the private constructors for utility classes
| @@ -33,21 +34,23 @@ | |||
|
|
|||
| public class Log { | |||
|
|
|||
| private Log() { | |||
There was a problem hiding this comment.
Utility classes (those that only contain static helper methods and classes) should have private constructors to stop people accidentally attempting to use the static methods as instance methods. Because "people"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test cases for Log and Console
Fixed some parsing bugs
modified to same convention we have in Network and Performance
Improved JavaDoc in Network
Usage of fromJson in all models
By placing an
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement