Add Chrome based Edge to the Ruby bindings #7257
Conversation
There was a problem hiding this comment.
I think is great for now.
Before we release 4.0, if Edge Chrome is production released, I think it should be what we provide with Selenium::WebDriver.for :edge and we should rename existing convenience method to :edge_legacy. It won't be backward compatible, but for a major version release, I think that's fine. We could also theoretically do some kind of handshake on Windows platforms as well, but that might be too complicated.
What do you think @p0deje ?
|
I've updated this to move the edge 18 into EdgeLegacy module, with Edge being an alias for it. Swapping from Edge/:edge being Legacy to Chrome based should be simple if/when chrome based edge goes release |
|
This is fine by me. I know that Java calls legacy |
|
I swapped the legacy edge namespace to EdgeHtml since that is what the engine is called -- thanks for pointing that out @p0deje. Anyone have issues with me squashing and merging this now? |
| end | ||
| end | ||
|
|
||
| # it 'should be able to run in headless mode with #headless!' do |
There was a problem hiding this comment.
It currently crashes when trying to start headless - not sure if they plan to support a headless mode or not
No issues from my side. Thanks for tackling this! |
twalpole
changed the title
Xin the preceding checkbox, I verify that I have signed the Contributor License AgreementThis is the start of adding Chrome based Edge to the Ruby bindings. We need to decide whether to implement this separately from legacy edge, or to accept some sort of configuration option to switch between legacy and chrome based - thoughts?