Enrich Target GCD #7285
Merged
Enrich Target GCD #7285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shs96c
approved these changes
Jun 20, 2019
| @@ -25,6 +25,7 @@ | |||
| import com.google.common.collect.ImmutableMap; | |||
| import com.google.common.collect.Multimap; | |||
|
|
|||
| import org.openqa.selenium.devtools.target.model.SessionId; | |||
There was a problem hiding this comment.
It fills me with endless sadness that we can't use Selenium's own SessionId here.
| @@ -57,24 +63,26 @@ public void close() { | |||
|
|
|||
| public void createSession() { | |||
| // Figure out the targets. | |||
| Set<Target.TargetInfo> infos = connection.sendAndWait(cdpSession, Target.getTargets(), timeout); | |||
| List<TargetInfo> infos = connection.sendAndWait(cdpSession, Target.getTargets(), timeout); | |||
There was a problem hiding this comment.
The ordering of targets doesn't matter, and we don't allow duplicates. Set is the right collection type to use.
| } | ||
|
|
||
| /** | ||
| * nject object to the target's main frame that provides a communication channel with browser |
|
|
||
| /** | ||
| * Creates a new empty BrowserContext. Similar to an incognito profile but you can have more than | ||
| * one.EXPERIMENTAL |
There was a problem hiding this comment.
Nit: the beta annotation shows that this is experimental.
| String url, | ||
| Optional<Integer> width, | ||
| Optional<Integer> height, | ||
| Optional<BrowserContextID> browserContextID, |
There was a problem hiding this comment.
Nit: BrowserContextId is preferable, and more in keeping with the naming conventions used in selenium.
| * automatically detaches from all currently attached targets.EXPERIMENTAL | ||
| */ | ||
| public static Command<Void> setAutoAttach( | ||
| Boolean autoAttach, Boolean waitForDebuggerOnStart, Optional<Boolean> flatten) { |
There was a problem hiding this comment.
We can clean this up in a later pass, but we can use primitives for parameters that are required. boolean, as we do elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary :
Enrich DevTools Target API according to Google documentation
Features:
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement