[rb] Add missing verification in timeout_spec.rb #7287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twalpole
reviewed
Jun 13, 2019
| @@ -34,7 +34,7 @@ module WebDriver | |||
| driver.manage.timeouts.implicit_wait = 6 | |||
|
|
|||
| driver.find_element(id: 'adder').click | |||
| driver.find_element(id: 'box0') | |||
| expect { driver.find_element(id: 'box0') }.not_to raise_error(WebDriver::Error::NoSuchElementError) | |||
There was a problem hiding this comment.
This should just be .not_to raise_error otherwise it potentially hides errors
There was a problem hiding this comment.
Thank you for your advice. Fixed it.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added verification because there is no verification in one of the tests in timeout_spec.rb.
Target test :
it 'should implicitly wait for a single element'Test passes have been verified with Travis CI results.
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement