[java] add full page screenshot feature for Firefox #7295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add FirefoxDriver calling /session/{session id}/moz/screenshot/full
* add unit test
|
This looks great, and I love how detailed the tests are. Thank you! Merging this now. Congratulations on your first commit to Selenium @takeya0x86! :) |
|
@shs96c Thank you! I had wanted to contribute to the project since SeConf Tokyo. So I'm happy now! |
|
Nice one! @takeya0x86 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Geckodriver v0.24.0 has new endpoint for full page screenshot. https://github.com/mozilla/geckodriver/releases/tag/v0.24.0
This commit allows java
FirefoxDriveruse of this function.FirefoxDrivermethod calling/session/{session id}/moz/screenshot/fullXin the preceding checkbox, I verify that I have signed the Contributor License Agreement