Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ApplicationCache from GoogleDev Tools #7424

Conversation

dratler
Copy link
Contributor

@dratler dratler commented Jul 23, 2019

Build ApplicationCache from Google Dev Tools
Add model
Add test
#6667

@p0deje p0deje added the C-java label Jul 23, 2019
Copy link
Member

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one small niggle, and I think this needs to be rebased after 62e09d6 (which is my change: sorry!)

.idea/codeStyles/codeStyleConfig.xml Show resolved Hide resolved
@shs96c
Copy link
Member

shs96c commented Aug 5, 2019

There appear to be unrelated changes in this PR. I'm not sure how the changes to the project configs or the python classes fit in, and the reformatting of NetworkInterceptor is confusing. Would it be possible to just focus this on adding the ApplicationCache CDP commands, please?

@dratler
Copy link
Contributor Author

dratler commented Aug 5, 2019

Hi @shs96c ,
I have done git pull upstream master to merge the code with current code to reduce conflicts.
I haven't add any thing else

@shs96c
Copy link
Member

shs96c commented Sep 10, 2019

Thanks for the PR. I've merged it as ef225e3

@shs96c shs96c closed this Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants