node/selenium-webdriver/firefox.js: accept zip webextensions #7464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
corevo
requested changes
Feb 26, 2020
Prior to this commit, the node.js firefox driver prevented loading webextensions the name of which did not end in '.xpi'. This was not very ergonomic as web-ext, the webextension-building tool created by Mozilla , produces files the name of which ends in '.zip' by default.
|
@corevo thanks for pointing out where the test should be added :). I believe everything's in order now, except the CI keeps failing. I think the reason it fails is that Travis tries to use an outdated cache. Could you clear my PR's cache and trigger a new build? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the node.js firefox driver prevented loading
webextensions the name of which did not end in '.xpi'. This was not very
ergonomic as web-ext, the webextension-building tool created by Mozilla
, produces files the name of which ends in '.zip' by default.
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement