Add SameSite attribute to Cookie
#7859
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cookie object in Selenium Java doesn't support setting `SameSite` attribute, described in the spce: https://tools.ietf.org/html/draft-ietf-httpbis-rfc6265bis-03#section-5.3.7 ChromeDriver already supports it. So improving Selenium Java API to support it as well. Partially fix #7798
|
|
* Add: Added W3C capability strictFileInteractability(c-nodejs)
This is to align with W3C WebDriver Spec. https://w3c.github.io/webdriver/#dfn-table-for-cookie-conversion
|
Sorry that this is my first time sending Pull Request to Selenium. I kind of messed up the commit history. Let me clean this up and try again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
SameSiteattribute toCookieMotivation and Context
Cookie object in Selenium Java doesn't support setting
SameSiteattribute, described in the spce:
https://tools.ietf.org/html/draft-ietf-httpbis-rfc6265bis-03#section-5.3.7
ChromeDriver already supports it. So improving Selenium Java API to
support it as well.
Partially fix #7798, i.e. the Java part. Other language bindings need to be checked to see if a fix is needed or not.
Types of changes
Checklist
I believe all the doc needs to be updated is the javadoc for the new field. Please let me know if there is any other document I need to update.