Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: Adding new cookie sameSite (c-nodejs) #7901

Merged
merged 6 commits into from
Mar 4, 2020
Merged

Add: Adding new cookie sameSite (c-nodejs) #7901

merged 6 commits into from
Mar 4, 2020

Conversation

harsha509
Copy link
Member

@harsha509 harsha509 commented Dec 30, 2019 •
edited
Loading

Signed-off-by: Sri Harsha [email protected]

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Description

Adding new cookie support 'sameSite' to c-nodejs

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

christian-bromann
christian-bromann reviewed Feb 11, 2020
View reviewed changes
Copy link
Contributor

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions.

javascript/node/selenium-webdriver/lib/webdriver.js Outdated Show resolved Hide resolved
javascript/node/selenium-webdriver/lib/webdriver.js Outdated Show resolved Hide resolved
christian-bromann
christian-bromann approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me now. 👍 Thanks!

@harsha509
Copy link
Member Author

This looks good to me now. 👍 Thanks!

Thanks for reviewing @christian-bromann .

@corevo corevo self-requested a review February 17, 2020 09:23
corevo
corevo requested changes Feb 24, 2020
View reviewed changes
Copy link
Member

@corevo corevo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to think about a better way to test this, since drivers according to the spec don't have to return the value.

javascript/node/selenium-webdriver/test/cookie_test.js Outdated Show resolved Hide resolved
corevo
corevo approved these changes Feb 27, 2020
View reviewed changes
Copy link
Member

@corevo corevo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires chromedriver 80, safaridriver & geckodriver have yet to implement.

@corevo corevo merged commit 7cbe4ae into SeleniumHQ:master Mar 4, 2020
@harsha509 harsha509 mentioned this pull request Mar 6, 2020
Merged
6 tasks
@n2o1988 n2o1988 mentioned this pull request Aug 27, 2020
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corevo corevo corevo approved these changes

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees
No one assigned
Labels
C-nodejs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harsha509 @christian-bromann @corevo @AutomatedTester