[grid] node registration #7949
Merged
[grid] node registration #7949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 19 commits
October 22, 2019 10:24
|
Adam Goucher seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
shs96c
reviewed
Jan 21, 2020
java/server/src/org/openqa/selenium/grid/distributor/local/LocalDistributor.java
Outdated
Show resolved
Hide resolved
java/server/src/org/openqa/selenium/grid/distributor/local/LocalDistributor.java
Outdated
Show resolved
Hide resolved
java/server/src/org/openqa/selenium/grid/component/HealthCheck.java
Outdated
Show resolved
Hide resolved
added 8 commits
January 21, 2020 20:19
…e to use Map. Using ImmutableMap.Builder now
…ings. IntelliJ says its not used, so who am I to argue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First whack at node registration. This only handles the initial registration not the ongoing communication which will be a separate work it.
There are no tests for this as it hooks off of the event bus answering method, and I have no idea how to do that. This PR is so we can have the conversation about exactly how to do that.