Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed maven central 501 error, using of https. #7961

Merged
merged 6 commits into from
Feb 15, 2020

Conversation

roldevg
Copy link
Contributor

@roldevg roldevg commented Jan 27, 2020

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Hi, guys!

I started to learn the documentation, but get an error on the screenshot.
So, we need to change the documentation for the actual link.

image

Effective January 15, 2020, The Central Repository no longer supports insecure communication over plain HTTP and requires that all requests to the repository are encrypted over HTTPS.

If you're receiving this error, then you need to replace all URL references to Maven Central with their canonical HTTPS counterparts:

Replace http://repo1.maven.org/maven2/ with https://repo1.maven.org/maven2/

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@claassistantio
Copy link

claassistantio commented Jan 27, 2020

CLA assistant check
All committers have signed the CLA.

@roldevg roldevg force-pushed the fix_maven_501 branch 2 times, most recently from 91c840a to 100aca1 Compare January 27, 2020 13:25
@roldevg
Copy link
Contributor Author

roldevg commented Jan 27, 2020

It seems the Travis CI has some problems with javadocs generation: https://travis-ci.com/SeleniumHQ/selenium/jobs/280443357

@roldevg roldevg requested review from diemol and shs96c January 29, 2020 08:12
Copy link
Member

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this, and welcome to the project!

@shs96c shs96c merged commit 62400e7 into SeleniumHQ:master Feb 15, 2020
@roldevg roldevg deleted the fix_maven_501 branch February 15, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants