Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify: (doc) getCookie throws 'NoSuchCookieError' and !null #8062

Merged
merged 1 commit into from
Feb 27, 2020
Merged

Modify: (doc) getCookie throws 'NoSuchCookieError' and !null #8062

merged 1 commit into from
Feb 27, 2020

Conversation

harsha509
Copy link
Member

@harsha509 harsha509 commented Feb 27, 2020

Description

Updating document for getCookie

As per webdriver documentation, getCookie should throw "NoSuchCookieError" if named cookie is not found.

In the documentation it is mentioned "null" will be returned if there is no named cookie in current browsing context.

This resolves issue #6292

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Sri Harsha <[email protected]>
@shs96c
Copy link
Member

shs96c commented Feb 27, 2020

Thank you for sending this! I'll merge it in now.

@shs96c shs96c merged commit 990b4de into SeleniumHQ:master Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants