Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform null check when calling Start on DriverService #8083

Merged
merged 4 commits into from
Mar 5, 2020
Merged

Perform null check when calling Start on DriverService #8083

merged 4 commits into from
Mar 5, 2020

Conversation

jordan-mace
Copy link
Contributor

@jordan-mace jordan-mace commented Mar 3, 2020

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Implements the null-check found in the Java bindings. For further details on the problem at hand, check out the description and comment thread of #8074

Motivation and Context

Fixes #8074

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@AutomatedTester AutomatedTester merged commit 73e6405 into SeleniumHQ:master Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FirefoxDriverService ProcessId property getting cleared when creating a FirefoxDriver
2 participants