Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Same site cookie feature in python bindings #8114

Merged
merged 9 commits into from
Mar 17, 2020
Merged

Add: Same site cookie feature in python bindings #8114

merged 9 commits into from
Mar 17, 2020

Conversation

harsha509
Copy link
Member

@harsha509 harsha509 commented Mar 16, 2020

Description

Adding sameSite Cookie feature to python bindings

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@harsha509
Copy link
Member Author

There are failures in the build that doesn't relate to the feature implemented. I can see my tests are passing in

https://travis-ci.com/github/SeleniumHQ/selenium/jobs/298568890

Snip20200316_1

Regards,
Harsha

@harsha509
Copy link
Member Author

hi @AutomatedTester ,

Thanks for reviewing the PR. I have a request here, as this feature is currently available in chrome only (and still in progress in FF),is there any way that we can exclude tests in Firefox?

Thanks,
Harsha

@harsha509
Copy link
Member Author

Hi @AutomatedTester ,

Apologies again. updated code with missing import

@AutomatedTester AutomatedTester merged commit 7b338ec into SeleniumHQ:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants