Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SameSite JSON key for Cookie to sameSite to align with WebDriver spec #8265

Merged
merged 2 commits into from
May 5, 2020
Merged

Fix SameSite JSON key for Cookie to sameSite to align with WebDriver spec #8265

merged 2 commits into from
May 5, 2020

Conversation

gjyalpha
Copy link

@gjyalpha gjyalpha commented May 1, 2020

spec https://w3c.github.io/webdriver/#dfn-table-for-cookie-conversion

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gjyalpha
Copy link
Author

gjyalpha commented May 4, 2020

Hi @gjyalpha,
Shouldn't this be changed here too?
https://github.com/SeleniumHQ/selenium/blob/master/java/client/src/org/openqa/selenium/remote/RemoteWebDriver.java#L774

Oops, good catch, Diego! I missed that. Let me fix that and make sure we have a test covering that use case.

@gjyalpha
Copy link
Author

gjyalpha commented May 4, 2020

Hi @diemol, I've fixed RemoteWebDriver.java. Please take a look.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gjyalpha!

@diemol diemol merged commit f4f60e9 into SeleniumHQ:master May 5, 2020
@gjyalpha
Copy link
Author

gjyalpha commented May 5, 2020

Hmm, it's not clear to me that failed test is related to my change or not.

Is there anyway I could retry that failed test on Travis CI? I tried to run the test locally with Bazel, but it seems it required Chrome 79. Not sure how I could setup Chrome 79 for Selenium test yet.

@gjyalpha gjyalpha deleted the fix-samesite-cookie-json-key branch May 5, 2020 16:33
titusfortner pushed a commit to titusfortner/selenium that referenced this pull request Aug 13, 2020
…r spec (SeleniumHQ#8265)

* Fix SameSite JSON key for Cookie to `sameSite` to align with WebDriver
spec https://w3c.github.io/webdriver/#dfn-table-for-cookie-conversion

* Fix SameSite JSON key for Cookie to `sameSite` in RemoteWebDriver.java
as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants