Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grid] Use heartbeat to register the Node #9321

Merged
merged 7 commits into from
Mar 23, 2021

Conversation

pujagani
Copy link
Contributor

@pujagani pujagani commented Mar 23, 2021

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Use the heartbeat to register the Node.
Related to #9297.

Motivation and Context

Currently, the Node uses the NodeStatus event to register itself with the Distributor. Once it is registered, it fires the NodeHeartbeat event at a configurable regular interval to indicate it is alive. If the Distributor goes down and comes up again, the same Node will not re-register on its own since it fires the NodeStatus event to register only when it spins up. So the Node(s) will have to be restarted so they register again.
To fix this behaviour, the changes here use the NodeHeartBeat to register the node and indicate it is alive.

Thank you @diemol for helping me understand the issue and potential solution.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sonarcloud
Copy link

sonarcloud bot commented Mar 23, 2021

@diemol diemol merged commit 995d897 into SeleniumHQ:trunk Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants