Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bazel] Ensure third party files are available for browser testing #9323

Merged
merged 2 commits into from
Mar 23, 2021
Merged

[bazel] Ensure third party files are available for browser testing #9323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4dad693
Ensure third party files are available for browser testing
pujagani Mar 23, 2021
0177d90
Merge branch 'trunk' into fix_functional_tests
diemol Mar 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions java/client/test/org/openqa/selenium/firefox/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ java_test_suite(
tags = [
"requires-network",
],
data = [
"//third_party/firebug:firebug-1.5.0-fx.xpi",
"//third_party/firebug:mooltipass-1.1.87.xpi",
],
deps = [
"//java/client/src/org/openqa/selenium/firefox",
"//java/client/src/org/openqa/selenium/remote",
Expand Down
3 changes: 0 additions & 3 deletions java/client/test/org/openqa/selenium/firefox/FirefoxProfileTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,6 @@ public void shouldInstallExtensionFromZip() {
}

@Test
@Ignore("Need to figure out why files are not showing up")
public void shouldInstallWebExtensionFromZip() {
profile.addExtension(InProject.locate(MOOLTIPASS_PATH).toFile());
File profileDir = profile.layoutOnDisk();
Expand All @@ -170,7 +169,6 @@ public void shouldInstallWebExtensionFromZip() {
}

@Test
@Ignore("Need to figure out why files are not showing up")
public void shouldInstallExtensionFromDirectory() throws IOException {
File extension = InProject.locate(FIREBUG_PATH).toFile();
File unzippedExtension = Zip.unzipToTempDir(new FileInputStream(extension), "unzip", "stream");
Expand All @@ -181,7 +179,6 @@ public void shouldInstallExtensionFromDirectory() throws IOException {
}

@Test
@Ignore("Need to figure out why files are not showing up")
public void shouldInstallWebExtensionFromDirectory() throws IOException {
File extension = InProject.locate(MOOLTIPASS_PATH).toFile();
File unzippedExtension = Zip.unzipToTempDir(new FileInputStream(extension), "unzip", "stream");
Expand Down
1 change: 0 additions & 1 deletion java/private/suite.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,6 @@ def java_selenium_test_suite(
size = None,
test_identifiers = ["Test.java"],
deps = None,
data = [],
jvm_flags = [],
tags = [],
**kwargs):
Expand Down